You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2016/08/23 07:56:12 UTC
Maven war plugin 3.x: can it finally include MWAR-262?
Hi guys,
just saw m-w-p 3.0.0 vote was on the list without
https://issues.apache.org/jira/browse/MWAR-262
When I asked about that some months ago the feedback was "not for a minor"
but for 3.0.0 I don't see why it couldn't have been done. Here is how I see
it:
- changing it now will not break existing app
- it will enable modern (EE 6 and therefore Servlet 3.0 was out in 1999 so
"modern") developments without any customization need (it is quite a pain
to have to configure it each time you create a war)
Would it be possible to re-evaluate this issue (and avoid to auto-close it
which more or less leads to ignoring it)?
Personally I don't see any issue having it fixed for 3.0.1.
wdyt?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
Re: Maven war plugin 3.x: can it finally include MWAR-262?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Le 23 août 2016 22:08, "Karl Heinz Marbaise" <kh...@gmx.de> a écrit :
>
> Hi Romains,
>
>
> On 23/08/16 09:56, Romain Manni-Bucau wrote:
>>
>> Hi guys,
>>
>> just saw m-w-p 3.0.0 vote was on the list without
>> https://issues.apache.org/jira/browse/MWAR-262
>
>
> Yes...
>
>
>>
>> When I asked about that some months ago the feedback was "not for a
minor"
>> but for 3.0.0 I don't see why it couldn't have been done. Here is how I
see
>> it:
>
>
> It hasn't been done simply cause this ticket has been closed in January
2016 which means seven months ago and before that this ticket has not been
touched for six years...without any reqeust to it nor any VOTE for it or at
least a supplemental comment to it. Nor has been ever attached a patch to
it?
>
>
> Unfortunately I couldn't find any request here on the DEV list from you
nor on the user list ...related to this (May be I oversight something)...
>
Hmm recall having created
http://maven.40175.n5.nabble.com/MNG-5327-set-failOnMissingWebXml-to-false-by-default-for-maven-war-plugin-td5717046.html
agter some exchanges but was maybe not on dev@
>
>>
>> - changing it now will not break existing app
>
>
> If I would really go and would change that only in a patch version this
would break backward compatibility...
>
Only for app expecting to not build which is not a big deal IMHO
> But:
>
> What I can do is to drop the release VOTE and change the default for the
value from "true" to "false" and respin the release...
>
> Checking the classpath for classes Java > 5 is not the purpose of the
maven-war-plugin...nor that simple...
>
Dont get that, the plugin is not intendes to do that whatever is the
default.
>
>
>> - it will enable modern (EE 6 and therefore Servlet 3.0 was out in 1999
so
>> "modern") developments without any customization need (it is quite a pain
>> to have to configure it each time you create a war)
>>
>> Would it be possible to re-evaluate this issue (and avoid to auto-close
it
>> which more or less leads to ignoring it)?
>
>
> The auto close was don cause it hasn't got an attention for six years ...
>
>
>
>>
>> Personally I don't see any issue having it fixed for 3.0.1.
>
>
> See my reasons above...
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
Re: Maven war plugin 3.x: can it finally include MWAR-262?
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Romains,
On 23/08/16 09:56, Romain Manni-Bucau wrote:
> Hi guys,
>
> just saw m-w-p 3.0.0 vote was on the list without
> https://issues.apache.org/jira/browse/MWAR-262
Yes...
>
> When I asked about that some months ago the feedback was "not for a minor"
> but for 3.0.0 I don't see why it couldn't have been done. Here is how I see
> it:
It hasn't been done simply cause this ticket has been closed in January
2016 which means seven months ago and before that this ticket has not
been touched for six years...without any reqeust to it nor any VOTE for
it or at least a supplemental comment to it. Nor has been ever attached
a patch to it?
Unfortunately I couldn't find any request here on the DEV list from you
nor on the user list ...related to this (May be I oversight something)...
>
> - changing it now will not break existing app
If I would really go and would change that only in a patch version this
would break backward compatibility...
But:
What I can do is to drop the release VOTE and change the default for the
value from "true" to "false" and respin the release...
Checking the classpath for classes Java > 5 is not the purpose of the
maven-war-plugin...nor that simple...
> - it will enable modern (EE 6 and therefore Servlet 3.0 was out in 1999 so
> "modern") developments without any customization need (it is quite a pain
> to have to configure it each time you create a war)
>
> Would it be possible to re-evaluate this issue (and avoid to auto-close it
> which more or less leads to ignoring it)?
The auto close was don cause it hasn't got an attention for six years ...
>
> Personally I don't see any issue having it fixed for 3.0.1.
See my reasons above...
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org