You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2009/12/24 19:10:29 UTC
[jira] Created: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Top-N queries produce incorrect results when followed by a cross statement
--------------------------------------------------------------------------
Key: PIG-1171
URL: https://issues.apache.org/jira/browse/PIG-1171
Project: Pig
Issue Type: Bug
Reporter: Richard Ding
Assignee: Richard Ding
??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
??Example code follows:??
{code}
A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
a = ORDER A BY f1 DESC;
b = ORDER B BY f1 DESC;
aa = LIMIT a 1;
bb = LIMIT b 1;
C = CROSS aa, bb;
DUMP C;
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1171) Top-N queries produce incorrect
results when followed by a cross statement
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794526#action_12794526 ]
Hadoop QA commented on PIG-1171:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428922/PIG-1171.patch
against trunk revision 893785.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/161/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/161/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/161/console
This message is automatically generated.
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Reporter: Richard Ding
> Assignee: Richard Ding
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1171:
------------------------------
Attachment: PIG-1171.patch
This patch provides a fix.
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Reporter: Richard Ding
> Assignee: Richard Ding
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1171.
---------------------------
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.7.0
>
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1171:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
patch committed. Thanks, Richard!
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.7.0
>
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1171:
------------------------------
Status: Patch Available (was: Open)
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Reporter: Richard Ding
> Assignee: Richard Ding
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1171) Top-N queries produce incorrect
results when followed by a cross statement
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796809#action_12796809 ]
Olga Natkovich commented on PIG-1171:
-------------------------------------
+1; patch looks good. Will be committing it to the trunk shortly
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.7.0
>
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1171) Top-N queries produce incorrect results
when followed by a cross statement
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1171:
--------------------------------
Affects Version/s: 0.6.0
Fix Version/s: 0.7.0
> Top-N queries produce incorrect results when followed by a cross statement
> --------------------------------------------------------------------------
>
> Key: PIG-1171
> URL: https://issues.apache.org/jira/browse/PIG-1171
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.7.0
>
> Attachments: PIG-1171.patch
>
>
> ??I am not sure if this is a bug, or something more subtle, but here is the problem that I am having.??
> ??When I LOAD a dataset, change it with an ORDER, LIMIT it, then CROSS it with itself, the results are not correct. I expect to see the cross of the limited, ordered dataset, but instead I see the cross of the limited dataset. Effectively, its like the LIMIT is being excluded.??
> ??Example code follows:??
> {code}
> A = load 'foo' as (f1:int, f2:int, f3:int); B = load 'foo' as (f1:int, f2:int, f3:int);
> a = ORDER A BY f1 DESC;
> b = ORDER B BY f1 DESC;
> aa = LIMIT a 1;
> bb = LIMIT b 1;
> C = CROSS aa, bb;
> DUMP C;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.