You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 16:43:16 UTC

[GitHub] [arrow] houqp commented on a change in pull request #9025: ARROW-10259: [Rust] Add custom metadata to Field

houqp commented on a change in pull request #9025:
URL: https://github.com/apache/arrow/pull/9025#discussion_r553446362



##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1500,6 +1590,7 @@ impl Field {
     }
 
     /// Merge field into self if it is compatible. Struct will be merged recursively.
+    /// NOTE: `self` may be updated to unexpected state in case of merge failure.

Review comment:
       yeah, i agree as well. would be better to have an atomic merge implementation done as a separate PR in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org