You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/06 02:58:08 UTC

[GitHub] [flink] zoltar9264 opened a new pull request, #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

zoltar9264 opened a new pull request, #20975:
URL: https://github.com/apache/flink/pull/20975

   …Range#contains()
   
   ## What is the purpose of the change
   
   fix java doc mistake in SequenceNumberRange#contains(), described in [FLINK-29526](https://issues.apache.org/jira/browse/FLINK-29526).
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1269242781

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c66a24b69aeef3692996da9066099f0c6d610a5e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c66a24b69aeef3692996da9066099f0c6d610a5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c66a24b69aeef3692996da9066099f0c6d610a5e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1269613818

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1275550883

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1281721579

   Hi @Myasuka , can you help me merge this pr ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] curcur commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
curcur commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1283852706

   @zoltar9264 , you can either merge the second commit to the first one or re-phrase it as "[hotfix] Remove Typo"
   
   Then I can merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] curcur merged pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
curcur merged PR #20975:
URL: https://github.com/apache/flink/pull/20975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1283863040

   Thanks @curcur , I have changed the second commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] masteryhx commented on a diff in pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
masteryhx commented on code in PR #20975:
URL: https://github.com/apache/flink/pull/20975#discussion_r990751814


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/SequenceNumberRange.java:
##########
@@ -29,7 +29,7 @@ public interface SequenceNumberRange {
     long size();
 
     /**
-     * @return true if {@link #from} &lt; sqn &lt; {@link #to} (this implies that the range is not
+     * @return true if {@link #from} &le; sqn &lt; {@link #to} (this implies that the range is not
      *     empty, i.e. to &gt; from))

Review Comment:
   minor: the number of right parenthesis should be just one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on a diff in pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on code in PR #20975:
URL: https://github.com/apache/flink/pull/20975#discussion_r991782319


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/SequenceNumberRange.java:
##########
@@ -29,7 +29,7 @@ public interface SequenceNumberRange {
     long size();
 
     /**
-     * @return true if {@link #from} &lt; sqn &lt; {@link #to} (this implies that the range is not
+     * @return true if {@link #from} &le; sqn &lt; {@link #to} (this implies that the range is not
      *     empty, i.e. to &gt; from))

Review Comment:
   Thanks @masteryhx , you are right. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #20975:
URL: https://github.com/apache/flink/pull/20975#issuecomment-1274040459

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org