You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 18:33:29 UTC

[GitHub] [airflow] dstandish opened a new pull request, #26995: No extra__conn_type__ prefix required for UI behaviors

dstandish opened a new pull request, #26995:
URL: https://github.com/apache/airflow/pull/26995

   After making it so we can omit the prefix in `get_connection_form_widgets`, we left `get_ui_field_behaviour` alone because, even though maybe it's unlikely and probably not a great idea, it's *possible* that a user would want to add an extra field that shares a name with an existing conn attr _and_ want to provide a placeholder for that field.
   
   But, after turning my attention back to this area, I think I arrived a at a reasonable way to solve this, which should make things easier for users when trying to implement extra fields for hooks.
   
   What we do is, check the placeholders when processing the hook in the providers manager, and if there are any fields which are not conn attrs and are not prefixed already, we add the prefix.  We don't need to worry about "hidden fields" or "relabeling" because these are only used with the built-in conn attrs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] dstandish merged pull request #26995: No extra__conn_type__ prefix required for UI behaviors

Posted by GitBox <gi...@apache.org>.
dstandish merged PR #26995:
URL: https://github.com/apache/airflow/pull/26995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org