You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 08:00:31 UTC

[GitHub] [airflow] jyotidhiman0610 opened a new pull request #13533: Fix Table not rendering in DAG Docs

jyotidhiman0610 opened a new pull request #13533:
URL: https://github.com/apache/airflow/pull/13533


   Closes https://github.com/apache/airflow/issues/10367


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jyotidhiman0610 commented on pull request #13533: Fix Table not rendering in DAG Docs

Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-760707348


   I re-based to latest master & pushed. Hoping the tests run now!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13533: Fix Table not rendering in DAG Docs

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-755966017


   Can you add tests to avoid regression?  It's also the easiest way to get reviews faster, as the reviewer won't have to run the change locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #13533: Support tables in DAG docs

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13533:
URL: https://github.com/apache/airflow/pull/13533


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #13533: Support tables in DAG docs

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-760885184


   Thanks @jyotidhiman0610 for your contribution. What's next? 🐈‍⬛


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jyotidhiman0610 edited a comment on pull request #13533: Support tables in DAG docs

Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 edited a comment on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-760884065


   Thanks @mik-laj for closing the issue :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #13533: Fix Table not rendering in DAG Docs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-756160510


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jyotidhiman0610 commented on pull request #13533: Fix Table not rendering in DAG Docs

Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-758658993


   @ryanahamilton @mik-laj I pushed a space to re-run the failing tests/(seemed unrelated) & get a green build on the PR. Post that, I think we can be good to merge.
   Do let me know if there is any other way to run failing tests. 
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jyotidhiman0610 commented on pull request #13533: Support tables in DAG docs

Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #13533:
URL: https://github.com/apache/airflow/pull/13533#issuecomment-760884065


   Thanks for closing @mik-laj /sparkle


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org