You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/19 18:56:23 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #174: [FLINK-27023] Unify flink and operator config handling
gyfora opened a new pull request, #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174
This PR configs a few changes that aims to unify config handling in the operator:
- Merge `operatorConfiguration` & `flinkConfiguration` sections of the values.yaml into `defaultConfiguration` with 3 supported keys
- flink-conf.yaml : shared default flink and operator config yaml
- log4j-operator.yaml : operator log config
- log4j-console.yaml : default flink deployment log config
- Prefix all kubernetes config options with `kubernetes.operator` to make it consistent with flink conventions
- In order to easily separate metrics configuration for the operator and flink jobs, operator metrics configs should now have a `kubernetes.operator.` prefix also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174#discussion_r853871854
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/OperatorMetricUtilsTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.operator.metrics;
+
+import org.apache.flink.configuration.Configuration;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
Review Comment:
good catch, will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174#issuecomment-1102981684
cc @morhidi @wangyang0918 @Aitozi @tweise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174#discussion_r853887878
##########
helm/flink-kubernetes-operator/conf/flink-conf.yaml:
##########
@@ -24,3 +25,16 @@ queryable-state.proxy.ports: 6125
jobmanager.memory.process.size: 1600m
taskmanager.memory.process.size: 1728m
parallelism.default: 2
+
+# Flink operator related configs
+# kubernetes.operator.reconciler.reschedule.interval: 60 s
+# kubernetes.operator.reconciler.max.parallelism: 5
+# kubernetes.operator.reconciler.flink.cancel.job.timeout: 1min
+# kubernetes.operator.reconciler.flink.cluster.shutdown.timeout: 60s
Review Comment:
```suggestion
# kubernetes.operator.reconciler.flink.cluster.shutdown.timeout: 60 s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174#discussion_r853888362
##########
helm/flink-kubernetes-operator/conf/flink-conf.yaml:
##########
@@ -24,3 +25,16 @@ queryable-state.proxy.ports: 6125
jobmanager.memory.process.size: 1600m
taskmanager.memory.process.size: 1728m
parallelism.default: 2
+
+# Flink operator related configs
+# kubernetes.operator.reconciler.reschedule.interval: 60 s
+# kubernetes.operator.reconciler.max.parallelism: 5
+# kubernetes.operator.reconciler.flink.cancel.job.timeout: 1min
Review Comment:
```suggestion
# kubernetes.operator.reconciler.flink.cancel.job.timeout: 1 min
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174#discussion_r853853234
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/OperatorMetricUtilsTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.operator.metrics;
+
+import org.apache.flink.configuration.Configuration;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
Review Comment:
nit: Maybe we need to use `org.junit.jupiter.api.Assertions.assertEquals` since we are explicitly using junit 5.
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/OperatorMetricUtilsTest.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.kubernetes.operator.metrics;
+
+import org.apache.flink.configuration.Configuration;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+
+/** @link OperatorMetricUtils tests. */
Review Comment:
```suggestion
/** {@link OperatorMetricUtils tests.} */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #174: [FLINK-27023] Unify flink and operator config handling
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #174:
URL: https://github.com/apache/flink-kubernetes-operator/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org