You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:27:59 UTC

[GitHub] [qpid-dispatch] jiridanek opened a new pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

jiridanek opened a new pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992


   There is a known issue with a transitive dependency `node-fs-extra` which, starting in version 9.0.0, needs at least nodejs 10 or maybe 10.3.
   
   https://github.com/google/docsy/issues/265 and https://github.com/jprichardson/node-fs-extra/issues/856


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] codecov-io commented on pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992#issuecomment-764427921


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=h1) Report
   > Merging [#992](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=desc) (5ffc398) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/86226ccf06bca50e6652f9cbaa171601c74abdab?el=desc) (86226cc) will **increase** coverage by `0.09%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/992/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #992      +/-   ##
   ==========================================
   + Coverage   78.94%   79.04%   +0.09%     
   ==========================================
     Files         111      111              
     Lines       28503    28502       -1     
   ==========================================
   + Hits        22502    22528      +26     
   + Misses       6001     5974      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/qpid/dispatch/buffer.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2J1ZmZlci5o) | `100.00% <ø> (ø)` | |
   | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `3.09% <ø> (+<0.01%)` | :arrow_up: |
   | [src/buffer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2J1ZmZlci5j) | `100.00% <ø> (ø)` | |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.35% <0.00%> (-0.08%)` | :arrow_down: |
   | [src/router\_core/delivery.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5Lmg=) | `100.00% <ø> (ø)` | |
   | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.62% <100.00%> (+0.19%)` | :arrow_up: |
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <100.00%> (ø)` | |
   | [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `82.39% <0.00%> (-0.67%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.84% <0.00%> (-0.22%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=footer). Last update [ec39e5e...5ffc398](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992#issuecomment-763845552


   @ganeshmurthy Travis is extremely slow to run, so I will leave this here until it runs and I see if it helped or not. (It's been already enqueued for 2 hours; I guess it will take until my tomorrow to see results.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek merged pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] codecov-io commented on pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992#issuecomment-764427921


   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=h1) Report
   > Merging [#992](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=desc) (5ffc398) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/86226ccf06bca50e6652f9cbaa171601c74abdab?el=desc) (86226cc) will **increase** coverage by `0.09%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/992/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #992      +/-   ##
   ==========================================
   + Coverage   78.94%   79.04%   +0.09%     
   ==========================================
     Files         111      111              
     Lines       28503    28502       -1     
   ==========================================
   + Hits        22502    22528      +26     
   + Misses       6001     5974      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/qpid/dispatch/buffer.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2J1ZmZlci5o) | `100.00% <ø> (ø)` | |
   | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `3.09% <ø> (+<0.01%)` | :arrow_up: |
   | [src/buffer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2J1ZmZlci5j) | `100.00% <ø> (ø)` | |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.35% <0.00%> (-0.08%)` | :arrow_down: |
   | [src/router\_core/delivery.h](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5Lmg=) | `100.00% <ø> (ø)` | |
   | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.62% <100.00%> (+0.19%)` | :arrow_up: |
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.95% <100.00%> (ø)` | |
   | [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `82.39% <0.00%> (-0.67%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.84% <0.00%> (-0.22%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/qpid-dispatch/pull/992/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=footer). Last update [ec39e5e...5ffc398](https://codecov.io/gh/apache/qpid-dispatch/pull/992?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek merged pull request #992: DISPATCH-1750 Set nodejs version to latest LTS on Travis

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #992:
URL: https://github.com/apache/qpid-dispatch/pull/992


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org