You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2021/01/05 23:38:00 UTC
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16926
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
QueueNode::not_admitted_reason can be accessed concurrently by the
coordinator thread that calls SubmitForAdmission and the admission
control dequeue loop thread.
This patch fixes this by ensuring that not_admitted_reason is only
accessed if 'admission_ctrl_lock_' is held.
Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
---
M be/src/scheduling/admission-controller.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/16926/1
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
QueueNode::not_admitted_reason can be accessed concurrently by the
coordinator thread that calls SubmitForAdmission and the admission
control dequeue loop thread.
This patch fixes this by ensuring that not_admitted_reason is only
accessed if 'admission_ctrl_lock_' is held.
Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Reviewed-on: http://gerrit.cloudera.org:8080/16926
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/admission-controller.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6830/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 18:30:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 01:33:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jan 2021 00:22:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7960/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 00:00:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10424: Fix race on not admitted reason in AdmissionController
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16926 )
Change subject: IMPALA-10424: Fix race on not_admitted_reason in AdmissionController
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb3f37d8e1797c2b1d7bc32ba6368419e9ae444
Gerrit-Change-Number: 16926
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jan 2021 18:30:37 +0000
Gerrit-HasComments: No