[GitHub] [jackrabbit-oak] lweitzendorf commented on a diff in pull request #692: OAK-9922 Parallel Compaction

[GitBox <gi...@apache.org>]

lweitzendorf commented on code in PR #692:
URL: https://github.com/apache/jackrabbit-oak/pull/692#discussion_r995408894


##########
oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordCacheStatsTest.java:
##########
@@ -37,18 +37,9 @@ public class RecordCacheStatsTest {
     private final Random rnd = new Random();
     private final MemoryStore store = new MemoryStore();
 
-    private final RecordCache<Integer> cache = newRecordCache(KEYS);
+    private final RecordCache<Integer> cache = newRecordCache(KEYS * 4 / 3);

Review Comment:
   The reason for this change in behavior is that the Guava cache may preemptively evict items for performance reasons. This means that filling the cache exactly to capacity no longer results in an eviction count of 0. I cannot change this behavior. What I can do is keep both implementations like with the SegmentBufferWriterPool and only use the concurrent cache for compaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org