[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4059: optimize test

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #4059: optimize test
URL: https://github.com/apache/incubator-shardingsphere/pull/4059#discussion_r368987464
 
 

 ##########
 File path: sharding-integration-test/sharding-jdbc-test/src/test/java/org/apache/shardingsphere/dbtest/engine/util/IntegrateTestParameters.java
 ##########
 @@ -67,7 +68,8 @@
             SQLCaseType caseType = (SQLCaseType) each[2];
             Class<?> sqlStatementClass = SQLParseEngineFactory.getSQLParseEngine(
                     DatabaseTypes.getTrunkDatabaseType(databaseType).getName()).parse(sqlCasesLoader.getSQL(sqlCaseId, SQLCaseType.Placeholder, Collections.emptyList()), false).getClass();
-            if (!sqlType.getSqlStatementClass().isAssignableFrom(sqlStatementClass)) {
+            if (!sqlType.getSqlStatementClass().isAssignableFrom(sqlStatementClass)
 
 Review comment:
   The code `SQLType.DML == sqlType && SelectStatement.class == sqlStatementClass` is difficult to understand.
   We need consider about it or add some comment to let develop know what happen

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services