[jira] [Work logged] (BEAM-6936) Add a Jenkins job running Java examples on Java 11 Dataflow

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-6936?focusedWorklogId=373935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373935 ]

ASF GitHub Bot logged work on BEAM-6936:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/20 23:16
            Start Date: 17/Jan/20 23:16
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on pull request #8183: [BEAM-6936] Added Jenkins jobs running Java examples on Dataflow with Java 11
URL: https://github.com/apache/beam/pull/8183#discussion_r368174524
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/examples/build.gradle
 ##########
 @@ -42,57 +42,59 @@ def dockerImageName = project(':beam-runners-google-cloud-dataflow-java').ext.do
 // If -PuseExecutableStage is set, the use_executable_stage_bundle_execution wil be enabled.
 def fnapiExperiments = project.hasProperty('useExecutableStage') ? 'beam_fn_api,use_executable_stage_bundle_execution' : "beam_fn_api"
 
+def commonConfig = { dataflowWorkerJar, workerHarnessContainerImage = '', additionalOptions = [] ->
+   // return the preevaluated configuration closure
+   return {
+       testClassesDirs = files(project(":beam-examples-java").sourceSets.test.output.classesDirs)
+       include "**/WordCountIT.class"
+       include "**/WindowedWordCountIT.class"
+       forkEvery 1
+       maxParallelForks 4
+   
+       def preCommitBeamTestPipelineOptions = [
+               "--project=${gcpProject}",
+               "--tempRoot=${gcsTempRoot}",
+               "--runner=TestDataflowRunner",
+               "--dataflowWorkerJar=${dataflowWorkerJar}",
+               workerHarnessContainerImage.isEmpty() ?'':"--workerHarnessContainerImage=${workerHarnessContainerImage}"
 
 Review comment:
   When `dataflowWorkerJar` is provided, the `workerHarnessContainerImage` should be set to empty explicitly, otherwise, the dataflow service will still try to pull harness image rather than using custom-built worker jar,
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 373935)
    Time Spent: 7h 10m  (was: 7h)

> Add a Jenkins job running Java examples on Java 11 Dataflow
> -----------------------------------------------------------
>
>                 Key: BEAM-6936
>                 URL: https://issues.apache.org/jira/browse/BEAM-6936
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-java, testing
>            Reporter: Michal Walenia
>            Assignee: Michal Walenia
>            Priority: Minor
>             Fix For: 2.14.0
>
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)