[kudu-CR] KUDU-2098. Drop Spark 1 Support

["Grant Henke (Code Review)" <ge...@cloudera.org>]

Grant Henke has posted comments on this change.

Change subject: KUDU-2098. Drop Spark 1 Support
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7690/2//COMMIT_MSG
Commit Message:

Line 9: Spark 2 has been available for over a year and the value of
> May want to throw a link to https://lists.apache.org/thread.html/1bcd0e048e
Done


http://gerrit.cloudera.org:8080/#/c/7690/2/java/README.md
File java/README.md:

Line 54: $ mvn verify
> Probably should call out that this requires Java 8, since it's 7 or 8 above
Done


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

Line 30:     <artifactId>kudu-${spark.version.label}-tools_${scala.binary.version}</artifactId>
> I think we should hard code this now, IntelliJ has a big problem with prope
I suspect down the line we will need to support spark3 or Scala 2.12. If it's not too big of an issue I would rather leave this. 

I think recent versions on IntelliJ handle this okay. Importing project via Gradle is an alternative workaround.


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
File java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala:

Line 41:       ss)
> keep the indent the same.
Done


http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 23:     <artifactId>kudu-${spark.version.label}_${scala.binary.version}</artifactId>
> Same here.  I wouldn't be against getting rid of all of the interpolation o
Yeah, I think leaving it for the sake of Spark 3 or Scala 2.12 is a good idea.


-- 
To view, visit http://gerrit.cloudera.org:8080/7690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes