You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2016/12/31 15:43:58 UTC
[jira] [Created] (HBASE-17399) region_mover.rb uses different
default filename, also needs slight change
Lars George created HBASE-17399:
-----------------------------------
Summary: region_mover.rb uses different default filename, also needs slight change
Key: HBASE-17399
URL: https://issues.apache.org/jira/browse/HBASE-17399
Project: HBase
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Lars George
The command line help prints:
{noformat}
-f, --filename=FILE File to save regions list into unloading, \
or read from loading; default /tmp/<hostname:port>
{noformat}
while in reality, the code does this:
{code}
def getFilename(options, targetServer, port)
filename = options[:file]
if not filename
filename = "/tmp/" + ENV['USER'] + targetServer + ":" + port
end
return filename
end
{code}
An example for a generated file is:
{noformat}
/tmp/larsgeorgeslave-3.internal.larsgeorge.com\:16020
{noformat}
I suggest we fix the command line help explanation. But first, we should also fix how the name is generated, *adding* a divider between the user name and the host name, and also change how the port is attached to the host name. Currently this results in a rather strange {{\:}} which could be hard to handle. Maybe we simply use an exclamation mark or hash for both? For example:
{noformat}
/tmp/larsgeorge!slave-3.internal.larsgeorge.com!16020
/tmp/larsgeorge#slave-3.internal.larsgeorge.com#16020
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)