You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by echauchot <gi...@git.apache.org> on 2017/04/24 09:22:54 UTC
[GitHub] beam pull request #2659: [BEAM-2029] null pointer exception while evaluating...
GitHub user echauchot opened a pull request:
https://github.com/apache/beam/pull/2659
[BEAM-2029] null pointer exception while evaluating group by key in spark runner in streaming mode
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @aviemzur
This PR, for now, just adds a test that raises a null pointer exception in spark runner so it cannot be merged as it is now. I don't know Spark runner well enough for now to do the fix. But I suspect that the problem is due to the `withFanout()` support in spark runner.
@aviemzur , can you take a look at the test and do the fix?
As we need the fix to have the build pass and merge this PR, what do you think about forking this PR and do the fix there, I will merge your PR and we will put the global PR (test + fix) to review and take care that your commits do not get squashed?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echauchot/beam BEAM-2029-NullPointerException_while_evaluating_GroupByKey_in_Spark_Runner_in_streaming_mode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2659.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2659
----
commit b68f0c5c2b507db7b66ee451208c0e19071ad7fd
Author: Etienne Chauchot <ec...@gmail.com>
Date: 2017-04-21T14:41:48Z
[BEAM-2029] NullPointerException while evaluating GroupByKey in Spark Runner in streaming mode
Add test to reproduce the NullPointerException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2659: [BEAM-2029] null pointer exception while evaluating...
Posted by echauchot <gi...@git.apache.org>.
Github user echauchot closed the pull request at:
https://github.com/apache/beam/pull/2659
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---