Re: Suggestions for small improvements in src/xercesc/util/ [patch] and samples/

[David Cargill <ca...@ca.ibm.com>]

Hi Jeroen,
Can you open a Jira bug so these changes don't get lost?

Also, in the bug report can you answer the due diligence questions in
section 7.3 of the charter  (http://xml.apache.org/xerces-c/charter.html)?
Alternatively, if you think you will continue to provide patches you might
want to file a CLA (section 7.2 of the charter).

Lastly, why do you want to make some of the XMLUri methods public?

Thanks.

Regards,
David A. Cargill
XML Parser Development
IBM Toronto Lab
(905) 413-2371, tie 969
cargilld@ca.ibm.com


                                                                           
             "Jeroen N.                                                    
             Witmond"                                                      
             <jn...@xs4all.nl>                                            To 
                                       c-dev@xerces.apache.org             
             09/17/2005 06:45                                           cc 
             AM                                                            
                                                                   Subject 
                                       Suggestions for small improvements  
             Please respond to         in src/xercesc/util/ [patch]        
                   c-dev               and samples/                        
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Greetings,

The attached patch makes the following small usability improvements:

- make a number of static helper methods in XMLUri.hpp public.

- adds methods to XMLString.hpp and XMLString.cpp to release strings using
a memory manager. In XMLString.hpp the comments/documentation are updated
as well.

The patch also fixes the compilation warning about comparison between
signed and unsigned in
src/xercesc/validators/schema/SchemaElementDecl.hpp. This problem was
mentioned before on the list, but the fix has not made it to svn yet.

For an improvement in samples/ I second the suggestion made by Neil Graham
on 10 december, 2003: "I'd also like to deprecate the SEnumVal and EnumVal
samples eventually; we certainly shouldn't be going out of our way to show
people how to use Xerces's internal interfaces!".

If a bug report is needed for any of the suggestions above, please let me
know.

Jeroen.
(See attached file: xerces-c-vanilla.patch)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org

Re: Suggestions for small improvements in src/xercesc/util/ [patch] and samples/

["Jeroen N. Witmond" <jn...@xs4all.nl>]

Hi David,

> Can you open a Jira bug so these changes don't get lost?

Done. http://issues.apache.org/jira/browse/XERCESC-1503

> Lastly, why do you want to make some of the XMLUri methods public?

They are useful, for instance when normalizing a URI. As they are static
and read-only, making them public should do no harm.

Regards,

Jeroen.



---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org