You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by kartik somani <ka...@gmail.com> on 2020/04/20 18:18:14 UTC

Re: IGNITE-12702 - Discussion

Hello Igniters,

I have created pull request for IGNITE-12702. Can someone review this?
https://github.com/apache/ignite/pull/7663

regards,
Kartik

On Mon, Mar 23, 2020 at 11:28 PM Denis Magda <dm...@apache.org> wrote:

> Hi Kartik,
>
> Actually, it means quite the opposite. You should fill in the release notes
> field before the ticket is resolved/closed so that a release manager of a
> next Ignite version adds a proper line to the final release notes with all
> the changes.
>
> As for the docs, it's highly likely you don't need to update Ignite
> technical documentation (apacheignite.readme.io), thus, the field should
> be
> disabled. However, see if APIs (Javadocs) require an update. Hope this
> helps. Btw, this page elaborates more on our current docs process that is
> being revisited and improved soon:
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document
>
> -
> Denis
>
>
> On Sun, Mar 22, 2020 at 6:33 AM kartik somani <
> kartiksomani.official@gmail.com> wrote:
>
> > Hello Igniters,
> >
> > I want to start working on ticket IGNITE-12702
> > <https://issues.apache.org/jira/browse/IGNITE-12702>.  The flags on this
> > issue are "Docs Required, Release Notes Required". Does this mean I have
> to
> > first write/get docs and release notes before starting work on this?
> >
> > Regards,
> > Kartik
> >
>

Re: IGNITE-12702 - Discussion

Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!

Unfortunately your merged change is not visible in this PR (0 files
changed). Please create your pull request off your feature branch, not
master.

Regards,
-- 
Ilya Kasnacheev


вс, 7 июн. 2020 г. в 20:20, kartik somani <ka...@gmail.com>:

> Hello,
>
> I have created a pull request for this issue
> <
> https://issues.apache.org/jira/browse/IGNITE-12702?jql=project%20%3D%20IGNITE%20AND%20labels%20in%20(newbie)%20and%20status%20%3D%20OPEN
> >
> : https://github.com/apache/ignite/pull/7882
> Can someone review?
>
> Regards,
> Kartik
>
> On Mon, Apr 20, 2020 at 11:48 PM kartik somani <
> kartiksomani.official@gmail.com> wrote:
>
> > Hello Igniters,
> >
> > I have created pull request for IGNITE-12702. Can someone review this?
> > https://github.com/apache/ignite/pull/7663
> >
> > regards,
> > Kartik
> >
> > On Mon, Mar 23, 2020 at 11:28 PM Denis Magda <dm...@apache.org> wrote:
> >
> >> Hi Kartik,
> >>
> >> Actually, it means quite the opposite. You should fill in the release
> >> notes
> >> field before the ticket is resolved/closed so that a release manager of
> a
> >> next Ignite version adds a proper line to the final release notes with
> all
> >> the changes.
> >>
> >> As for the docs, it's highly likely you don't need to update Ignite
> >> technical documentation (apacheignite.readme.io), thus, the field
> should
> >> be
> >> disabled. However, see if APIs (Javadocs) require an update. Hope this
> >> helps. Btw, this page elaborates more on our current docs process that
> is
> >> being revisited and improved soon:
> >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document
> >>
> >> -
> >> Denis
> >>
> >>
> >> On Sun, Mar 22, 2020 at 6:33 AM kartik somani <
> >> kartiksomani.official@gmail.com> wrote:
> >>
> >> > Hello Igniters,
> >> >
> >> > I want to start working on ticket IGNITE-12702
> >> > <https://issues.apache.org/jira/browse/IGNITE-12702>.  The flags on
> >> this
> >> > issue are "Docs Required, Release Notes Required". Does this mean I
> >> have to
> >> > first write/get docs and release notes before starting work on this?
> >> >
> >> > Regards,
> >> > Kartik
> >> >
> >>
> >
>

Re: IGNITE-12702 - Discussion

Posted by kartik somani <ka...@gmail.com>.
Hello,

I have created a pull request for this issue
<https://issues.apache.org/jira/browse/IGNITE-12702?jql=project%20%3D%20IGNITE%20AND%20labels%20in%20(newbie)%20and%20status%20%3D%20OPEN>
: https://github.com/apache/ignite/pull/7882
Can someone review?

Regards,
Kartik

On Mon, Apr 20, 2020 at 11:48 PM kartik somani <
kartiksomani.official@gmail.com> wrote:

> Hello Igniters,
>
> I have created pull request for IGNITE-12702. Can someone review this?
> https://github.com/apache/ignite/pull/7663
>
> regards,
> Kartik
>
> On Mon, Mar 23, 2020 at 11:28 PM Denis Magda <dm...@apache.org> wrote:
>
>> Hi Kartik,
>>
>> Actually, it means quite the opposite. You should fill in the release
>> notes
>> field before the ticket is resolved/closed so that a release manager of a
>> next Ignite version adds a proper line to the final release notes with all
>> the changes.
>>
>> As for the docs, it's highly likely you don't need to update Ignite
>> technical documentation (apacheignite.readme.io), thus, the field should
>> be
>> disabled. However, see if APIs (Javadocs) require an update. Hope this
>> helps. Btw, this page elaborates more on our current docs process that is
>> being revisited and improved soon:
>> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document
>>
>> -
>> Denis
>>
>>
>> On Sun, Mar 22, 2020 at 6:33 AM kartik somani <
>> kartiksomani.official@gmail.com> wrote:
>>
>> > Hello Igniters,
>> >
>> > I want to start working on ticket IGNITE-12702
>> > <https://issues.apache.org/jira/browse/IGNITE-12702>.  The flags on
>> this
>> > issue are "Docs Required, Release Notes Required". Does this mean I
>> have to
>> > first write/get docs and release notes before starting work on this?
>> >
>> > Regards,
>> > Kartik
>> >
>>
>