[GitHub] [flink] rkhachatryan commented on a diff in pull request #20091: [FLINK-27570][runtime]Count finalize failure in checkpoint manager

[GitBox <gi...@apache.org>]

rkhachatryan commented on code in PR #20091:
URL: https://github.com/apache/flink/pull/20091#discussion_r922878505


##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -1368,6 +1369,15 @@ private CompletedCheckpoint finalizeCheckpoint(PendingCheckpoint pendingCheckpoi
                                 CheckpointFailureReason.FINALIZE_CHECKPOINT_FAILURE, e1));
             }
 
+            if (e1 instanceof FlinkExpectedException) {

Review Comment:
   I'm afraid `FlinkExcpectedException` will never reach this line
   because it will be caught in `PendingCheckpoint.finalizeCheckpoint` and wrapped into `IOException` there.
   Replacing `FlinkExpectedException` with `FlinkRuntimeException` shoudll be enough though.
   
   This also suggests that some test is necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org