You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/26 09:10:07 UTC
[GitHub] [incubator-kyuubi] jiaoqingbo commented on a diff in pull request #2753: [KYUUBI #2752] Kyuubi Spark TPC-DS Connector - configurable catalog's name by initialize method
jiaoqingbo commented on code in PR #2753:
URL: https://github.com/apache/incubator-kyuubi/pull/2753#discussion_r882474093
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSCatalog.scala:
##########
@@ -37,10 +37,13 @@ class TPCDSCatalog extends TableCatalog with SupportsNamespaces {
var options: CaseInsensitiveStringMap = _
- override def name: String = "tpcds"
+ var _name: Option[String] = None
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org