You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Volkan Yazici (Jira)" <ji...@apache.org> on 2022/11/24 13:34:00 UTC

[jira] [Commented] (LOG4J2-3637) Spotless build plugin failing in CI is way too late

    [ https://issues.apache.org/jira/browse/LOG4J2-3637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638294#comment-17638294 ] 

Volkan Yazici commented on LOG4J2-3637:
---------------------------------------

[~mattsicker], judging from my personal experience, any check that is not part of the build but _an assumption_ on the host system always gets forgotten over time. Consider FindBugs and dozens of other _reports_ that are supposed to be checked by developers. Can't we simply run {{spotless:apply}} at an early stage of the build? I mean, in the worst case we can (ugh!) wrap it with {{{}exec-maven-plugin{}}}, right? But, please, not git hooks.

> Spotless build plugin failing in CI is way too late
> ---------------------------------------------------
>
>                 Key: LOG4J2-3637
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3637
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Build
>            Reporter: Matt Sicker
>            Priority: Major
>
> Applying auto-formatting as required for a clean build should be implemented as a git pre-commit hook.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)