You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RongtongJin (via GitHub)" <gi...@apache.org> on 2023/06/21 14:39:32 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request, #6927: [ISSUE #6926] Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start.
RongtongJin opened a new pull request, #6927:
URL: https://github.com/apache/rocketmq/pull/6927
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6926
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start.
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6927: [ISSUE #6926] Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6927:
URL: https://github.com/apache/rocketmq/pull/6927#issuecomment-1603602406
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6927](https://app.codecov.io/gh/apache/rocketmq/pull/6927?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f04e2b8) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/4e09a9cfe9eb47cac4302f6e2ca6b40e9ec04470?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4e09a9c) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6927 +/- ##
=============================================
+ Coverage 42.61% 42.62% +0.01%
- Complexity 9173 9176 +3
=============================================
Files 1131 1131
Lines 80225 80224 -1
Branches 10469 10468 -1
=============================================
+ Hits 34184 34193 +9
+ Misses 41767 41758 -9
+ Partials 4274 4273 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://app.codecov.io/gh/apache/rocketmq/pull/6927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `44.01% <0.00%> (+0.04%)` | :arrow_up: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6927/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #6927: [ISSUE #6926] Fixing the error in the initialization order of replicasManager caused the controller mode to fail to start.
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #6927:
URL: https://github.com/apache/rocketmq/pull/6927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org