You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2020/05/06 19:04:33 UTC
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15867
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
IMPALA-9541: [DOCS] add steps to dynamically change log levels
added a new section to change log levels dynamically
also elaborated the Glog format
Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
---
M docs/topics/impala_logging.xml
1 file changed, 158 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/15867/1
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 02:47:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/367/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 02:26:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/596/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 16:46:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 02:25:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 02:26:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml
File docs/topics/impala_logging.xml:
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@44
PS1, Line 44: <p> The Impala logs record information about: </p>
Just curious: there are many formatting changes like these. Are they nessasary, i.e. the old codes violating any code styles?
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@195
PS1, Line 195: By default this
: page displays the current running log level of the service.
The current log levels are not shown in this page. But users can query the log4j log level of "root" or "org.apache.impala" by using the "Get Java Log Level" button.
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@204
PS1, Line 204: Log Levels.
Can we mention that this is a one character info and their meaning are "I=INFO, W=WARNING, E=ERROR, F=FATAL" ?
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@208
PS1, Line 208: PID/TID of the process/thread.
I think there are no PID for process.
http://gerrit.cloudera.org:8080/#/c/15867/1/docs/topics/impala_logging.xml@211
PS1, Line 211: user-specified
remove this word? Logs are generated by the system(impala).
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 04:16:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
IMPALA-9541: [DOCS] add steps to dynamically change log levels
added a new section to change log levels dynamically, made review changes
also elaborated the Glog format, remove the word PROCESS
Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Reviewed-on: http://gerrit.cloudera.org:8080/15867
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_logging.xml
1 file changed, 165 insertions(+), 245 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15867/2/docs/topics/impala_logging.xml
File docs/topics/impala_logging.xml:
http://gerrit.cloudera.org:8080/#/c/15867/2/docs/topics/impala_logging.xml@214
PS2, Line 214: process/
remove "process/"
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 08:04:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/591/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 19:04:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15867
to look at the new patch set (#3).
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
IMPALA-9541: [DOCS] add steps to dynamically change log levels
added a new section to change log levels dynamically, made review changes
also elaborated the Glog format, remove the word PROCESS
Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
---
M docs/topics/impala_logging.xml
1 file changed, 165 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/15867/3
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/594/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 17:46:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15867
to look at the new patch set (#2).
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
IMPALA-9541: [DOCS] add steps to dynamically change log levels
added a new section to change log levels dynamically, made review changes
also elaborated the Glog format
Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
---
M docs/topics/impala_logging.xml
1 file changed, 165 insertions(+), 245 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/15867/2
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/596/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2020 17:06:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/591/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2020 19:12:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9541: [DOCS] add steps to dynamically change log levels
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15867 )
Change subject: IMPALA-9541: [DOCS] add steps to dynamically change log levels
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/594/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72fbfe3218530f5a1ffa0159ce714e411401bcd
Gerrit-Change-Number: 15867
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 17:33:37 +0000
Gerrit-HasComments: No