You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/25 11:15:14 UTC
[GitHub] [airflow] turbaszek opened a new pull request #9512: Extract common date log logic in _run_raw_task
turbaszek opened a new pull request #9512:
URL: https://github.com/apache/airflow/pull/9512
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9512: Extract common date log logic in _run_raw_task
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9512:
URL: https://github.com/apache/airflow/pull/9512#discussion_r445483755
##########
File path: airflow/models/taskinstance.py
##########
@@ -1014,7 +1020,6 @@ def signal_handler(signum, frame):
# If a timeout is specified for the task, make it fail
# if it goes beyond
- result = None
Review comment:
This was an unused argument, so I decided to remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9512: Extract common date log logic in _run_raw_task
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9512:
URL: https://github.com/apache/airflow/pull/9512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #9512: Extract common date log logic in _run_raw_task
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #9512:
URL: https://github.com/apache/airflow/pull/9512#discussion_r445504606
##########
File path: airflow/models/taskinstance.py
##########
@@ -930,6 +930,12 @@ def check_and_change_state_before_execution(
self.log.info("Executing %s on %s", self.task, self.execution_date)
return True
+ def _date_or_empty(self, attr):
+ if hasattr(self, attr):
+ date = getattr(self, attr)
+ return date.strftime('%Y%m%dT%H%M%S') if date else ''
Review comment:
```suggestion
if date:
return date.strftime('%Y%m%dT%H%M%S')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org