You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/24 07:18:10 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #7317: bugfix: when both route and global rules setted proxy-rewrite plugin,…

spacewander commented on code in PR #7317:
URL: https://github.com/apache/apisix/pull/7317#discussion_r905784885


##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -185,6 +185,7 @@ function _M.rewrite(conf, ctx)
         upstream_uri = core.utils.uri_safe_encode(upstream_uri)
     end
 
+    ctx.var.upstream_uri = nil

Review Comment:
   The fix LGTM ( I can't give a better fix yet). Would be better to add a comment that we purge the cache by assigning a nil value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org