[GitHub] [superset] rusackas commented on pull request #12613: feat: [WIP] Quick POC of rendering all charts in iframes on dashboards

[GitBox <gi...@apache.org>]

rusackas commented on pull request #12613:
URL: https://github.com/apache/superset/pull/12613#issuecomment-763978504


   Much to figure out here indeed, but I wanted to start fiddling around in the open, when time allows. Undoubtedly, this will require solving a few puzzles, but I hope it's not TOO painful. The library in use is maintained by some zendesk folk, who use it for their embedded widgets. The reason I was looking at that was originally for viz plugin sandboxing purposes. Previously any plugin code could have full access to the `window` object, which is full of security pitfalls. No big deal when they're _our_ plugins that we maintain, but in broadening scope to community contributed viz plugins, this was one of many areas to shore up. I'm hoping we can get some other benefits out of it too though, so consider this whole PR a big "tire kick". A feature flag sounds like a perfectly reasonable idea as long as the code is easy to keep isolated, so I'll pencil that in as part of the plan!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org