You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/08 15:05:00 UTC
[jira] [Commented] (CB-13984) Fix issue with toolbar navigation
buttons always being hidden on iOS
[ https://issues.apache.org/jira/browse/CB-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429780#comment-16429780 ]
ASF GitHub Bot commented on CB-13984:
-------------------------------------
jcesarmobile opened a new pull request #264: CB-13984: (ios) Fix toolbar navigation buttons always being hidden
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/264
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fix issue with toolbar navigation buttons always being hidden
### What testing has been done on this change?
tested on iOS device
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Fix issue with toolbar navigation buttons always being hidden on iOS
> --------------------------------------------------------------------
>
> Key: CB-13984
> URL: https://issues.apache.org/jira/browse/CB-13984
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Reporter: Rasim Kanca
> Priority: Major
>
> In CB-13409, the functionality to hide the toolbar navigation buttons was added for iOS through the *hidenavigationbuttons* property. Unfortunately, in the iOS code, after checking whether the property is defined and what it is, it defaults to hiding the buttons completely ignoring the value of the property.
> The line in question can be viewed [here|https://github.com/apache/cordova-plugin-inappbrowser/commit/8711ee3f211bf84913ae86f81e5e0e548d1c8015#diff-aa3201a8ef3df73e28e8979eaa6e228eR657]. There is a pull request that contains a commit with a fix in [this pull request|https://github.com/apache/cordova-plugin-inappbrowser/pull/260].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org