You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2013/08/13 20:40:32 UTC

Review Request 13540: [HELIX-153] Auto rebalance tester uses the returned map fields, but production only uses list fields

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13540/
-----------------------------------------------------------

Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.


Bugs: HELIX-153


Repository: helix-git


Description
-------

Fix for HELIX-153. The auto rebalance tester was using partition mappings computed by the new rebalancing strategy, but we don't use them anywhere in production. The test now uses the existing code paths.


Diffs
-----

  helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 0ae4baf 

Diff: https://reviews.apache.org/r/13540/diff/


Testing
-------

Tests pass locally.


Thanks,

Kanak Biscuitwala


Re: Review Request 13540: [HELIX-153] Auto rebalance tester uses the returned map fields, but production only uses list fields

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13540/#review25442
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On Aug. 22, 2013, 11:32 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13540/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 11:32 p.m.)
> 
> 
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
> 
> 
> Bugs: HELIX-153
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> Fix for HELIX-153. The auto rebalance tester was using partition mappings computed by the new rebalancing strategy, but we don't use them anywhere in production. The test now uses the existing code paths.
> 
> 
> Diffs
> -----
> 
>   helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 8533572 
> 
> Diff: https://reviews.apache.org/r/13540/diff/
> 
> 
> Testing
> -------
> 
> Tests pass locally.
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>


Re: Review Request 13540: [HELIX-153] Auto rebalance tester uses the returned map fields, but production only uses list fields

Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13540/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 11:32 p.m.)


Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.


Changes
-------

Cleaned up the test some more to generalize it.


Bugs: HELIX-153


Repository: helix-git


Description
-------

Fix for HELIX-153. The auto rebalance tester was using partition mappings computed by the new rebalancing strategy, but we don't use them anywhere in production. The test now uses the existing code paths.


Diffs (updated)
-----

  helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 8533572 

Diff: https://reviews.apache.org/r/13540/diff/


Testing
-------

Tests pass locally.


Thanks,

Kanak Biscuitwala