You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Shreepadma Venugopalan <sh...@cloudera.com> on 2014/03/12 23:13:33 UTC
Review Request 19160: SENTRY-136: Thrift request structs should include the
groupName in addition to the userName
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19160/
-----------------------------------------------------------
Review request for sentry and Brock Noland.
Bugs: SENTRY-136
https://issues.apache.org/jira/browse/SENTRY-136
Repository: sentry
Description
-------
Adds groupName to all the thrift request structs. Cleans up the interface.
Diffs
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java 86dcc54
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java a1530d1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 237f55d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 43a6055
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java a1e09fd
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java cb7cf0b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java c63a673
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java b035b12
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9796562
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 7c54290
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java dae7674
Diff: https://reviews.apache.org/r/19160/diff/
Testing
-------
Existing tests pass. Integration test needed modification.
Thanks,
Shreepadma Venugopalan
Re: Review Request 19160: SENTRY-136: Thrift request structs should include
the groupName in addition to the userName
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19160/#review37017
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On March 12, 2014, 11:37 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19160/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 11:37 p.m.)
>
>
> Review request for sentry and Brock Noland.
>
>
> Bugs: SENTRY-136
> https://issues.apache.org/jira/browse/SENTRY-136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adds groupName to all the thrift request structs. Cleans up the interface.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java 86dcc54
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java a1530d1
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 237f55d
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 43a6055
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java a1e09fd
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java cb7cf0b
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java c63a673
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java b035b12
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9796562
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff4817f
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 7c54290
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java dae7674
>
> Diff: https://reviews.apache.org/r/19160/diff/
>
>
> Testing
> -------
>
> Existing tests pass. Integration test needed modification.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 19160: SENTRY-136: Thrift request structs should include
the groupName in addition to the userName
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19160/
-----------------------------------------------------------
(Updated March 12, 2014, 11:37 p.m.)
Review request for sentry and Brock Noland.
Changes
-------
Feedback from review.
Bugs: SENTRY-136
https://issues.apache.org/jira/browse/SENTRY-136
Repository: sentry
Description
-------
Adds groupName to all the thrift request structs. Cleans up the interface.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java 86dcc54
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java a1530d1
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 237f55d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 43a6055
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java a1e09fd
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java cb7cf0b
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java c63a673
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java b035b12
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9796562
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff4817f
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 7c54290
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java dae7674
Diff: https://reviews.apache.org/r/19160/diff/
Testing
-------
Existing tests pass. Integration test needed modification.
Thanks,
Shreepadma Venugopalan
Re: Review Request 19160: SENTRY-136: Thrift request structs should include
the groupName in addition to the userName
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19160/#review37011
-----------------------------------------------------------
When looking all the fields of the various request objects I get a little confused. Should we change userName and groupName to something like:
2: ... string requestorUserName;
3: ... set<string> requestorUserGroupNames
to signify where they are coming from? or similar?
- Brock Noland
On March 12, 2014, 10:13 p.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19160/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 10:13 p.m.)
>
>
> Review request for sentry and Brock Noland.
>
>
> Bugs: SENTRY-136
> https://issues.apache.org/jira/browse/SENTRY-136
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adds groupName to all the thrift request structs. Cleans up the interface.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleAddGroupsRequest.java 86dcc54
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleDeleteGroupsRequest.java a1530d1
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleGrantPrivilegeRequest.java 237f55d
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TAlterSentryRoleRevokePrivilegeRequest.java 43a6055
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TCreateSentryRoleRequest.java a1e09fd
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TDropSentryRoleRequest.java cb7cf0b
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesRequest.java c63a673
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TListSentryRolesResponse.java b035b12
> sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9796562
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 7c54290
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java dae7674
>
> Diff: https://reviews.apache.org/r/19160/diff/
>
>
> Testing
> -------
>
> Existing tests pass. Integration test needed modification.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>