You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2023/02/20 14:42:22 UTC
[GitHub] [nuttx] anchao opened a new pull request, #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
anchao opened a new pull request, #8599:
URL: https://github.com/apache/nuttx/pull/8599
## Summary
tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Wrong warning array subscript [0] is outside array bounds:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
ci-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #8599:
URL: https://github.com/apache/nuttx/pull/8599#discussion_r1112206120
##########
arch/arm/src/common/Toolchain.defs:
##########
@@ -227,6 +227,13 @@ else
ARCHOPTIMIZATION += -fno-builtin
endif
endif
+
+ # Skip -Warray-bounds check due to bug of GCC-12.2:
+ # Wrong warning array subscript [0] is outside array bounds:
+ # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
+
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #8599:
URL: https://github.com/apache/nuttx/pull/8599#discussion_r1112205731
##########
arch/arm/src/common/Toolchain.defs:
##########
@@ -227,6 +227,13 @@ else
ARCHOPTIMIZATION += -fno-builtin
endif
endif
+
+ # Skip -Warray-bounds check due to bug of GCC-12.2:
+ # Wrong warning array subscript [0] is outside array bounds:
+ # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
+
Review Comment:
Ok, min-pagesize is a newly added option of GCC-12. It seems that most open source projects use this option for workaround. I think we can add gcc version checks to avoid breaks on other versions of the compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8599:
URL: https://github.com/apache/nuttx/pull/8599#issuecomment-1437738989
let's merge this patch to unblock ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8599:
URL: https://github.com/apache/nuttx/pull/8599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] btashton commented on a diff in pull request #8599: tools/ci: skip -Warray-bounds check due to bug of GCC-12.2
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on code in PR #8599:
URL: https://github.com/apache/nuttx/pull/8599#discussion_r1112148725
##########
arch/arm/src/common/Toolchain.defs:
##########
@@ -227,6 +227,13 @@ else
ARCHOPTIMIZATION += -fno-builtin
endif
endif
+
+ # Skip -Warray-bounds check due to bug of GCC-12.2:
+ # Wrong warning array subscript [0] is outside array bounds:
+ # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105523
+
Review Comment:
Instead of disabling this globally since it is a good check, can we do as the ticket suggests and set
```
--param=min-pagesize=0
```
As needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org