Re: [PR] fix(streamlit): read state logs as utf-8 [burr]

["Ghraven (via GitHub)" <gi...@apache.org>]

Ghraven commented on PR #907:
URL: https://github.com/apache/burr/pull/907#issuecomment-5986549602

   Thanks for the careful review. I reproduced the missing-matplotlib failure in an isolated Python 3.9 environment. c31b0c2 adds the matplotlib/colors stubs and loads the integration under a temporary module name, so the stubbed module does not remain cached as burr.integrations.streamlit. The reader now closes the log with a context manager, and the test checks that too.
   
   The focused regression passes without installing matplotlib; Black, isort, Flake8, license-header checks and diff checks pass. I have not run the full optional-integration suite. Current head checks show successful labeling/mergeability checks, not a full test run.
   
   Agreed on scope: the UTF-8 fix matters for custom serializers or externally produced non-ASCII logs; the default ensure_ascii=True writer generally produces ASCII.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org