You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/27 22:47:46 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #5364: Add more symbols to syscall.csv and libc.csv
yamt opened a new pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364
## Summary
Add more symbols to syscall.csv and libc.csv
## Impact
## Testing
tested with my local app.
this changes made it loadable at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1025246860
> Do you think the commit logs like this is make sense to other developers?
yes.
> this can definitely be solved with a single commit !
why? i explained why i did this way.
> I bet that if the similar changes are commit to other active communities, they will certainly vote against it .
i bet differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1024841695
Do you think the commit logs like this is make sense to other developers? this can definitely be solved with a single commit !
I bet that if the similar changes are commit to other active communities, they will certainly vote against it .
```
commit 794df92fc98a0d54be5203c1f9681c18328eaba5 (HEAD, origin/master, origin/HEAD)
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 19:41:21 2022 +0900
libs/libc/libc.csv: Add feof
commit 82fdba525896df7c30e59014fa396e6bcbefdbec
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 19:17:29 2022 +0900
libs/libc/libc.csv: Add truncate
commit 182575d24086260e7b9a608341301e1cfe990421
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 19:07:27 2022 +0900
libs/libc/libc.csv: Add localtime and ctime
commit 0db6ac28d81da1e9c19891cec48d202e0212f240
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 18:54:29 2022 +0900
libs/libc/libc.csv: Add atoi and friends
commit 4b183b93cf45537f5903d54ef89f46d36b7bdfbb
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 17:39:28 2022 +0900
libs/libc/libc.csv: Add mktemp and its friends
commit 113992c0377520676a4179f6c6d8a4a9f11d5fae
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 17:27:44 2022 +0900
libs/libc/libc.csv: Add gettimeofday
commit 5ebfb70427c5466fc4ccfa04ec379f8e278e9804
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 17:19:27 2022 +0900
libs/libc/libc.csv: Add pthread_cond_timedwait
commit 741a1d21490529726604a0a1bff09c3e84a4dcbe
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 17:10:02 2022 +0900
libs/libc/libc.csv: Add pthread_create
commit bbfd0667fcbc055cd0959c38fb07811e31d098a3
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 16:54:25 2022 +0900
libs/libc/libc.csv: Add uname
commit ebbfa034c798a31396c8d21459befcc83bd4fcec
Author: YAMAMOTO Takashi <ya...@midokura.com>
Date: Thu Jan 27 16:24:40 2022 +0900
libs/libc/libc.csv: Add shutdown
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1023851003
How about merging the c interface changes into one commit? these does not have new implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1024919919
Hmmm, Isn't this why Squash should be enabled on our repos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1023859908
> How about merging the c interface changes into one commit? these does not have new implementations
for me, it's easier to deal with this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1023879718
> for me, it's easier to deal with this way.
Seriously, I do not quite agree with this way ... this will make the git commit history become garbage, if everyone split the commit line by line, there are a lot of commits in NuttX, but the code implementation is not really meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5364: Add more symbols to libc.csv
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5364:
URL: https://github.com/apache/incubator-nuttx/pull/5364#issuecomment-1023886298
> > for me, it's easier to deal with this way.
>
> Seriously, I do not quite agree with this way ... this will make the git commit history become garbage, if everyone split the commit line by line, there are a lot of commits in NuttX, but the code implementation is not really meaningful.
it's about logical separation. not about line by line separation.
i actually had to fix/replace/drop a few of these commits. it would have been more cumbersome if it was a single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org