You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/09/21 18:19:38 UTC

[arrow] branch master updated: ARROW-3287: [C++] Suppress "redeclared without dllimport attribute" warning from MinGW

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 7edfbae  ARROW-3287: [C++] Suppress "redeclared without dllimport attribute" warning from MinGW
7edfbae is described below

commit 7edfbae58fd8a164fd4d6bd656634902ded7109d
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Fri Sep 21 14:19:25 2018 -0400

    ARROW-3287: [C++] Suppress "redeclared without dllimport attribute" warning from MinGW
    
    This fixes the following warning from MinGW:
    
        ../apache-arrow-0.11.0/c_glib/../cpp/src/arrow/status.h:265:8: warning: 'arrow::Status::Status(arrow::Status&&)' redeclared without dllimport attribute after being referenced with dll linkage
         inline Status::Status(Status&& s) noexcept : state_(s.state_) { s.state_ = NULL; }
                ^~~~~~
    
    Author: Kouhei Sutou <ko...@clear-code.com>
    
    Closes #2602 from kou/cpp-add-missing-inline and squashes the following commits:
    
    d4c18a750 <Kouhei Sutou>  Add missing inline
---
 cpp/src/arrow/status.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpp/src/arrow/status.h b/cpp/src/arrow/status.h
index 2a652c8..24ae2e8 100644
--- a/cpp/src/arrow/status.h
+++ b/cpp/src/arrow/status.h
@@ -110,7 +110,7 @@ class ARROW_EXPORT Status {
   Status& operator=(const Status& s);
 
   // Move the specified status.
-  Status(Status&& s) noexcept;
+  inline Status(Status&& s) noexcept;
   Status& operator=(Status&& s) noexcept;
 
   // AND the statuses.