You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/21 08:39:51 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
JiriOndrusek opened a new pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488
Issue: https://github.com/apache/camel-quarkus/issues/1471
As a part of the solution `extension-support/bouncycastle` was created. Bouncy castle security provider is required for camel-as2 and without proper initialization there are no digests working with quarkus in native.
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#issuecomment-676038076
There seems to be more issues to solve. I'm closing for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#discussion_r457994905
##########
File path: extensions-support/bouncycastle/runtime/pom.xml
##########
@@ -0,0 +1,80 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-support-bouncycastle-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-support-bouncycastle</artifactId>
+ <name>Camel Quarkus :: Support :: Bouncy Castle :: Runtime</name>
+
+ <properties>
+ <firstVersion>1.0.0-M6</firstVersion>
Review comment:
Should be `1.0.0-CR4`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#issuecomment-661734410
@oscerd I'll look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#discussion_r458025991
##########
File path: extensions-support/bouncycastle/runtime/pom.xml
##########
@@ -0,0 +1,80 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-support-bouncycastle-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-support-bouncycastle</artifactId>
+ <name>Camel Quarkus :: Support :: Bouncy Castle :: Runtime</name>
+
+ <properties>
+ <firstVersion>1.0.0-M6</firstVersion>
Review comment:
I've created this file manually and missed that one, I' fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#issuecomment-662394583
Change in camel - https://github.com/apache/camel/pull/4031 - fixes failed tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] oscerd commented on pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488#issuecomment-661731034
@JiriOndrusek since you have some experience with as2, would you mind creating also an example of usage in camel-examples? Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek closed pull request #1488: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek closed pull request #1488:
URL: https://github.com/apache/camel-quarkus/pull/1488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org