[jira] Closed: (MNG-2691) DefaultPluginManager.addPlugin() doesn't tell which plugin is broken

["Brett Porter (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MNG-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter closed MNG-2691.
-----------------------------

         Assignee: Brett Porter
       Resolution: Cannot Reproduce
    Fix Version/s:     (was: Reviewed Pending Version Assignment)

error has been fixed, and can't reproduce the second problem now

> DefaultPluginManager.addPlugin() doesn't tell which plugin is broken
> --------------------------------------------------------------------
>
>                 Key: MNG-2691
>                 URL: http://jira.codehaus.org/browse/MNG-2691
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 2.0.5
>            Reporter: Aaron Digulla
>            Assignee: Brett Porter
>
> In DefaultPluginManager.addPlugin() is code like this:
> throw new IllegalStateException( "The PluginDescriptor for the plugin " + plugin + " was not found." );
> Unfortunately, "plugin" has no toString(), so you just see the Java classname and the object id.
> Replace all three places with "plugin.getKey()" or, even better, add a new method to Plugin which also includes the version string if there is one.
> Also the error message of the IllegalStateException should be:
> "The PluginDescriptor for the plugin " + plugin.getKey() + " was not found. Are you sure this is a Maven plugin and not a normal dependency?"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira