You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/03/02 01:10:09 UTC
Review Request: Added support to decline an offer (rather than relying on
understanding the semantics of 'launchTasks' with an empty task list).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/
-----------------------------------------------------------
Review request for mesos and Andy Konwinski.
Summary
-------
See summary.
Diffs
-----
include/mesos/scheduler.hpp fcb6bc1
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 78ad788
src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
src/python/src/mesos.py c6ff24e
src/sched/sched.cpp 9f5866b
Diff: https://reviews.apache.org/r/4141/diff
Testing
-------
make && make check && make hadoop
Thanks,
Benjamin
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-05 06:20:31, John Sirois wrote:
> > src/java/src/org/apache/mesos/SchedulerDriver.java, line 89
> > <https://reviews.apache.org/r/4141/diff/1/?file=87195#file87195line89>
> >
> > This note needs updating.
Updated (here and in scheduler.hpp).
> On 2012-03-05 06:20:31, John Sirois wrote:
> > src/java/src/org/apache/mesos/SchedulerDriver.java, line 116
> > <https://reviews.apache.org/r/4141/diff/1/?file=87195#file87195line116>
> >
> > How does lifecycle work? Must I decline inside a launchTasks - or can this happen after launchTasks returns?
Updated (here and in scheduler.hpp).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/#review5610
-----------------------------------------------------------
On 2012-03-02 00:10:09, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4141/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 00:10:09)
>
>
> Review request for mesos and Andy Konwinski.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp fcb6bc1
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 78ad788
> src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
> src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
> src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
> src/python/src/mesos.py c6ff24e
> src/sched/sched.cpp 9f5866b
>
> Diff: https://reviews.apache.org/r/4141/diff
>
>
> Testing
> -------
>
> make && make check && make hadoop
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/#review5610
-----------------------------------------------------------
I think this may be awesome pending docs explaining lifecycle.
src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/4141/#comment12228>
This note needs updating.
src/java/src/org/apache/mesos/SchedulerDriver.java
<https://reviews.apache.org/r/4141/#comment12229>
How does lifecycle work? Must I decline inside a launchTasks - or can this happen after launchTasks returns?
- John
On 2012-03-02 00:10:09, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4141/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 00:10:09)
>
>
> Review request for mesos and Andy Konwinski.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp fcb6bc1
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 78ad788
> src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
> src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
> src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
> src/python/src/mesos.py c6ff24e
> src/sched/sched.cpp 9f5866b
>
> Diff: https://reviews.apache.org/r/4141/diff
>
>
> Testing
> -------
>
> make && make check && make hadoop
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-21 06:49:36, John Sirois wrote:
> >
Thanks! Submitting.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/#review6168
-----------------------------------------------------------
On 2012-03-20 23:04:13, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4141/
> -----------------------------------------------------------
>
> (Updated 2012-03-20 23:04:13)
>
>
> Review request for mesos and Andy Konwinski.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 6c28f41
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 98ee484
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 46e5351
> src/java/src/org/apache/mesos/SchedulerDriver.java d591c1f
> src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
> src/python/native/mesos_scheduler_driver_impl.cpp 39f7ffa
> src/python/src/mesos.py c6ff24e
> src/sched/sched.cpp 16770a1
>
> Diff: https://reviews.apache.org/r/4141/diff
>
>
> Testing
> -------
>
> make && make check && make hadoop
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/#review6168
-----------------------------------------------------------
Ship it!
- John
On 2012-03-20 23:04:13, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4141/
> -----------------------------------------------------------
>
> (Updated 2012-03-20 23:04:13)
>
>
> Review request for mesos and Andy Konwinski.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp 6c28f41
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 98ee484
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 46e5351
> src/java/src/org/apache/mesos/SchedulerDriver.java d591c1f
> src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
> src/python/native/mesos_scheduler_driver_impl.cpp 39f7ffa
> src/python/src/mesos.py c6ff24e
> src/sched/sched.cpp 16770a1
>
> Diff: https://reviews.apache.org/r/4141/diff
>
>
> Testing
> -------
>
> make && make check && make hadoop
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/
-----------------------------------------------------------
(Updated 2012-03-20 23:04:13.200921)
Review request for mesos and Andy Konwinski.
Changes
-------
Review comments.
Summary
-------
See summary.
Diffs (updated)
-----
include/mesos/scheduler.hpp 6c28f41
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 98ee484
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 46e5351
src/java/src/org/apache/mesos/SchedulerDriver.java d591c1f
src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
src/python/native/mesos_scheduler_driver_impl.cpp 39f7ffa
src/python/src/mesos.py c6ff24e
src/sched/sched.cpp 16770a1
Diff: https://reviews.apache.org/r/4141/diff
Testing
-------
make && make check && make hadoop
Thanks,
Benjamin
Re: Review Request: Added support to decline an offer (rather than relying
on understanding the semantics of 'launchTasks' with an empty task list).
Posted by Andy Konwinski <an...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4141/#review5609
-----------------------------------------------------------
Ship it!
I think this will make the API much more intuitive.
- Andy
On 2012-03-02 00:10:09, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4141/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 00:10:09)
>
>
> Review request for mesos and Andy Konwinski.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/scheduler.hpp fcb6bc1
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 78ad788
> src/java/src/org/apache/mesos/SchedulerDriver.java a59fe96
> src/python/native/mesos_scheduler_driver_impl.hpp 34e9e1f
> src/python/native/mesos_scheduler_driver_impl.cpp 2652bfe
> src/python/src/mesos.py c6ff24e
> src/sched/sched.cpp 9f5866b
>
> Diff: https://reviews.apache.org/r/4141/diff
>
>
> Testing
> -------
>
> make && make check && make hadoop
>
>
> Thanks,
>
> Benjamin
>
>