[GitHub] Antonio-Maranhao commented on issue #1072: Fix query options reducer code

[GitBox <gi...@apache.org>]

Antonio-Maranhao commented on issue #1072: Fix query options reducer code
URL: https://github.com/apache/couchdb-fauxton/pull/1072#issuecomment-378456048
 
 
   Thanks @popojargo - that was a very bad rebase I did. It's fixed now. 
   
   By 'unknown' I meant I don't know the reason why the minified code generated in `bundle.js` was not semantically equivalent to the original code.
   The original `getQueryOptionsParams` in #1071 is :
   ```
   export const getQueryOptionsParams = (state) => {
     const {queryOptionsPanel} = state;
     const params = {};
   
     if (queryOptionsPanel.includeDocs) {
       params.include_docs = queryOptionsPanel.includeDocs;
     }
   
     if (queryOptionsPanel.showBetweenKeys) {
       const betweenKeys = queryOptionsPanel.betweenKeys;
       params.inclusive_end = betweenKeys.include;
       if (betweenKeys.startkey && betweenKeys.startkey != '') {
         params.start_key = betweenKeys.startkey;
       }
       if (betweenKeys.endkey && betweenKeys.endkey != '') {
         params.end_key = betweenKeys.endkey;
       }
     } else if (queryOptionsPanel.showByKeys) {
       if (queryOptionsPanel.byKeys.trim()) {
         params.keys = queryOptionsPanel.byKeys.replace(/\r?\n/g, '');
       }
     }
   
     if (queryOptionsPanel.limit !== 'none') {
       params.limit = parseInt(queryOptionsPanel.limit, 10);
     }
   
     if (queryOptionsPanel.skip) {
       params.skip = parseInt(queryOptionsPanel.skip, 10);
     }
   
     if (queryOptionsPanel.descending) {
       params.descending = queryOptionsPanel.descending;
     }
   
     if (queryOptionsPanel.reduce) {
       params.reduce = true;
   
       if (queryOptionsPanel.groupLevel === 'exact') {
         params.group = true;
       } else {
         params.group_level = queryOptionsPanel.groupLevel;
       }
     }
   
     // Only add UPDATE and STABLE parameters when different than
     // their respective default values. This prevent errors in
     // older CouchDB versions that don't support these parameters.
     if (queryOptionsPanel.update !== undefined) {
       // Default value is 'true'
       if (queryOptionsPanel.update !== 'true') {
         params.update = queryOptionsPanel.update;
       }
     }
   
     if (typeof queryOptionsPanel.stable === 'boolean') {
       // Default value is false
       if (queryOptionsPanel.stable === true) {
         params.stable = queryOptionsPanel.stable;
       }
     }
   
     return params;
   };
   ```
   
   And the corresponding code in `bundle.js` is: 
   ```
   getQueryOptionsParams=function(e){
     var t=e.queryOptionsPanel,a={};
     if(t.includeDocs&&(a.include_docs=t.includeDocs),t.showBetweenKeys){var n=t.betweenKeys;a.inclusive_end=n.include,n.startkey&&""!=n.startkey&&(a.start_key=n.startkey),n.endkey&&""!=n.endkey&&(a.end_key=n.endkey)} else t.showByKeys&&t.byKeys.trim()&&(a.keys=t.byKeys.replace(/\r?\n/g,""));return"none"!==t.limit&&(a.limit=parseInt(t.limit,10)),t.skip&&(a.skip=parseInt(t.skip,10)),t.descending&&(a.descending=t.descending),t.reduce&&(a.reduce=!0,"exact"===t.groupLevel?a.group=!0:a.group_level=t.groupLevel),void 0!==t.update&&(a.update=t.update),"boolean"==typeof t.stable&&(a.stable=t.stable),a}
   ```
   
   Using `getQueryOptionsParams({queryOptionsPanel: {includeDocs: true, stable: false, update: "true"}})` as an example, the original code returns `{include_docs: true, limit: NaN}` but the version in `bundle.js` returns `{include_docs: true, limit: NaN, update: "true", stable: false}`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services