You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Roland Weber <ht...@dubioso.net> on 2006/08/27 13:14:19 UTC

Re: svn commit: r437358

Hi Oleg,

just a few minor observations:

EventMask: unless you're going to add more, this should either
be an interface or have the default constructor disabled.

IOSession: the get/set/removeAttribute methods look exactly
like those in HttpContext. Derive the session from the context?

No JavaDoc warnings ;-)

cheers,
  Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Re: svn commit: r437358

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sun, 2006-08-27 at 13:14 +0200, Roland Weber wrote:
> Hi Oleg,
> 
> just a few minor observations:
> 
> EventMask: unless you're going to add more, this should either
> be an interface or have the default constructor disabled.
> 

Good point.

> IOSession: the get/set/removeAttribute methods look exactly
> like those in HttpContext. Derive the session from the context?
> 

Good point.

> No JavaDoc warnings ;-)
> 

No javadocs - no javadocs warnings ;-)

Oleg

> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org