[GitHub] [superset] john-bodley commented on a diff in pull request #23113: chore(sqla): Performance tradeoff with eager loading

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #23113:
URL: https://github.com/apache/superset/pull/23113#discussion_r1110383294


##########
superset/connectors/sqla/models.py:
##########
@@ -551,13 +549,11 @@ class SqlaTable(Model, BaseDatasource):  # pylint: disable=too-many-public-metho
         TableColumn,
         back_populates="table",
         cascade="all, delete-orphan",
-        lazy="selectin",  # Only non-eager loading that works with bidirectional joined.

Review Comment:
   The default is `lazy="select"` (which is akin to `lazy=True`), i.e., the relationships are lazy loaded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org