[GitHub] [hudi] SteNicholas commented on a diff in pull request #8188: [MINOR] Improve instantToWrite

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #8188:
URL: https://github.com/apache/hudi/pull/8188#discussion_r1138037717


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/TimeWait.java:
##########
@@ -54,10 +54,11 @@ public static Builder builder() {
   public void waitFor() {
     try {
       if (waitingTime > timeout) {
-        throw new HoodieException("Timeout(" + waitingTime + "ms) while waiting for " + action);
+        LOG.warn("Timeout(" + waitingTime + "ms) while waiting for " + action);

Review Comment:
   @hbgstc123 +1. And I think if timeout, throwing exception makes sense to me. Otherwise how the timeout works?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org