You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/26 12:18:28 UTC
[GitHub] [shardingsphere] boyjoy1127 opened a new pull request, #22444: 19937 federation optimization 20221121
boyjoy1127 opened a new pull request, #22444:
URL: https://github.com/apache/shardingsphere/pull/22444
Ref #19937.
Changes proposed in this pull request:
- modify case code style
- add schema information in optimization test cases.
---
Before committing this PR, I'm sure that I have checked the following options:
- [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [X] I have self-reviewed the commit code.
- [X] I have (or in comment I request) added corresponding labels for the pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [X] I have made corresponding changes to the documentation.
- [X] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o merged pull request #22444: 19937 federation optimization 20221121
Posted by GitBox <gi...@apache.org>.
yx9o merged PR #22444:
URL: https://github.com/apache/shardingsphere/pull/22444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22444: 19937 federation optimization 20221121
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22444:
URL: https://github.com/apache/shardingsphere/pull/22444#issuecomment-1328041613
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22444](https://codecov.io/gh/apache/shardingsphere/pull/22444?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98152ef) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0160f941322ddede730f3acc6b8cea8cae153940?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0160f94) will **decrease** coverage by `0.01%`.
> The diff coverage is `24.18%`.
```diff
@@ Coverage Diff @@
## master #22444 +/- ##
============================================
- Coverage 51.05% 51.04% -0.02%
+ Complexity 2506 2499 -7
============================================
Files 4157 4178 +21
Lines 57685 58016 +331
Branches 9785 9870 +85
============================================
+ Hits 29451 29614 +163
- Misses 25702 25877 +175
+ Partials 2532 2525 -7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/rewriter/EncryptPredicateParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL3Jld3JpdGVyL0VuY3J5cHRQcmVkaWNhdGVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `4.54% <0.00%> (-0.22%)` | :arrow_down: |
| [...ator/EncryptPredicateRightValueTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL0VuY3J5cHRQcmVkaWNhdGVSaWdodFZhbHVlVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `53.84% <0.00%> (ø)` | |
| [...data/DefaultDataSourcePoolPropertiesValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvRGVmYXVsdERhdGFTb3VyY2VQb29sUHJvcGVydGllc1ZhbGlkYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...metadata/type/c3p0/C3P0DataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9jM3AwL0MzUDBEYXRhU291cmNlUG9vbE1ldGFEYXRhLmphdmE=) | `83.33% <0.00%> (-2.39%)` | :arrow_down: |
| [...metadata/type/dbcp/DBCPDataSourcePoolMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvbWV0YWRhdGEvdHlwZS9kYmNwL0RCQ1BEYXRhU291cmNlUG9vbE1ldGFEYXRhLmphdmE=) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
| [...ollector/ShardingSphereTableDataCollectorUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL2NvbGxlY3Rvci9TaGFyZGluZ1NwaGVyZVRhYmxlRGF0YUNvbGxlY3RvclV0aWwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/data/collector/tables/PgClassTableCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL2NvbGxlY3Rvci90YWJsZXMvUGdDbGFzc1RhYmxlQ29sbGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ta/collector/tables/PgNamespaceTableCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL2NvbGxlY3Rvci90YWJsZXMvUGdOYW1lc3BhY2VUYWJsZUNvbGxlY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...shardingsphere/infra/util/retry/RetryExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9yZXRyeS9SZXRyeUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mode/repository/cluster/nacos/NacosRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L2NsdXN0ZXIvbmFjb3MvTmFjb3NSZXBvc2l0b3J5LmphdmE=) | `74.46% <0.00%> (ø)` | |
| ... and [1189 more](https://codecov.io/gh/apache/shardingsphere/pull/22444/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org