You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/11/18 07:21:58 UTC
[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2678
[ZEPPELIN-3063] Notebook loses formatting when importing from 0.6.x
### What is this PR for?
Notebook loses formatting (shows table instead of the graph) when importing from 0.6.x if the respective paragraph doesn't have result in it.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3063](https://issues.apache.org/jira/browse/ZEPPELIN-3063)
### How should this be tested?
* Try importing [this](https://issues.apache.org/jira/secure/attachment/12898326/oldnotebook-0.6-clear.json) notebook, and then on running this notebook, the second paragraph should display BarChart instead of a table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2678
----
commit d2805aacad492208af688fb0e391859a58419b6f
Author: prabhjyotsingh <pr...@gmail.com>
Date: 2017-11-18T07:13:57Z
ZEPPELIN-3063: Notebook loses formatting when importing from 0.6.x
Change-Id: I8132db6e24cfb499a770b5bed4eb475754f0db78
----
---
[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2678
---
[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2678
[ZEPPELIN-3063] Notebook loses formatting when importing from 0.6.x
### What is this PR for?
Notebook loses formatting (shows table instead of the graph) when importing from 0.6.x if the respective paragraph doesn't have result in it.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3063](https://issues.apache.org/jira/browse/ZEPPELIN-3063)
### Screenshots (if appropriate)
Before:
After:
### How should this be tested?
* Try importing [this](https://issues.apache.org/jira/secure/attachment/12898326/oldnotebook-0.6-clear.json) notebook, and then on running this notebook, the second paragraph should display BarChart instead of a table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3063
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2678
----
commit 1975c74e7758d8a52d3ccc68f098cc5d3f126b74
Author: prabhjyotsingh <pr...@gmail.com>
Date: 2017-11-18T07:13:57Z
ZEPPELIN-3063: Notebook loses formatting when importing from 0.6.x
Change-Id: I8132db6e24cfb499a770b5bed4eb475754f0db78
commit 3824eed015cbcb164ef5f3267802f75a174c7d60
Author: Prabhjyot <pr...@gmail.com>
Date: 2017-11-19T03:10:11Z
Add comment support for 0.6
----
---
[GitHub] zeppelin pull request #2678: [ZEPPELIN-3063] Notebook loses formatting when ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2678
---
[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2678
Merging this if no more discussion.
---
[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2678
Thanks for the review, have made the suggested changes
---
[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2678
Tested and LGTM
---