You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org> on 2010/01/01 03:22:29 UTC
[jira] Created: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Trinidad 2: ppr error when interacting with programatically added component
---------------------------------------------------------------------------
Key: TRINIDAD-1671
URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
Project: MyFaces Trinidad
Issue Type: Bug
Reporter: Gabrielle Crawford
wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Starets resolved TRINIDAD-1671.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0.1-plugins)
2.0.0.1-core
Oops - used wrong 'fixed' version
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
> Assignee: Max Starets
> Fix For: 2.0.0.1-core
>
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796362#action_12796362 ]
Gabrielle Crawford commented on TRINIDAD-1671:
----------------------------------------------
ok, so you don't have to wait for the fix for 1670, the only thing you need to do before running is turn off the change manager by chaning the change persistence web.xml param like so:
<context-param>
<param-name>org.apache.myfaces.trinidad.CHANGE_PERSISTENCE</param-name>
<param-value>org.apache.myfaces.trinidad.change.NullChangeManager</param-value>
</context-param>
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Starets resolved TRINIDAD-1671.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-plugins
The offending code has been in PPRResponseWriter forever:
super.write("<?Tr-XHR-Response-Type ?>\n"); should have been:
_xml.write("<?Tr-XHR-Response-Type ?>\n");
This was putting PPRResponseWriter into the 'forceInsideTarget' mode, so all output was sent to the client. The problem used to be masked by Trinidad's ResponseWriterDecorator overriding all write() methods. It got exposed once we started relying on JSF's ResponseWriterWrapper
Note: we need to reevaluate whether the 'forceInsideTarget' mode is even necessary with the current version of Facelets.
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
> Assignee: Max Starets
> Fix For: 2.0.1-plugins
>
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Max Starets (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Starets reopened TRINIDAD-1671:
-----------------------------------
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
> Assignee: Max Starets
> Fix For: 2.0.0.1-core
>
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796673#action_12796673 ]
Matthias Weßendorf commented on TRINIDAD-1671:
----------------------------------------------
forget the patch... it was for TRINIDAD-1674 ...
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1671) Trinidad 2: ppr error when
interacting with programatically added component
Posted by "Gabrielle Crawford (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798881#action_12798881 ]
Gabrielle Crawford commented on TRINIDAD-1671:
----------------------------------------------
I think there's a general issue with swallowing errors, for example I'm getting a ppr error here too:
1. run partialAddComponent.jspx and follow the link "set up for state saving test"
2. modify web.xml to test partial state saving
3. shut down and restart partialAddComponent.jspx
4. click the "add a component" button
5. open the showDetail
> Trinidad 2: ppr error when interacting with programatically added component
> ---------------------------------------------------------------------------
>
> Key: TRINIDAD-1671
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1671
> Project: MyFaces Trinidad
> Issue Type: Bug
> Reporter: Gabrielle Crawford
>
> wait for the fix for https://issues.apache.org/jira/browse/TRINIDAD-1670, or move "_parent = parent;" to the top of UIXComponentBase.setParent, which is a workaround for 1670.
> Now run stateSaving/partialAddComponent.jspx. You don't need to set up partial state saving or change web.xml, just try adding the component, and then opening the showDetail, when it asks you to reload the page hit cancel and look at the js error.
> The js error starts with: ["Invalid PPR response. The response-headers were:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.