You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/30 21:29:58 UTC
[GitHub] [superset] codemaster08240328 opened a new pull request #19450: feat: Remove legacy sql alchemy db connection link from G Sheet connection
codemaster08240328 opened a new pull request #19450:
URL: https://github.com/apache/superset/pull/19450
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When we add google sheet as a database, we still have legacy SQLAlchemy url connection method, which is not supported anymore.
So removed this from the GSheet connection.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
<img width="574" alt="image" src="https://user-images.githubusercontent.com/39701522/160933822-6d6ae3ee-853f-4a7d-86ba-834e6f93e8ac.png">
After:
<img width="599" alt="image" src="https://user-images.githubusercontent.com/39701522/160933658-7f6e9518-041d-4c50-952a-c33ad22ba7dd.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19450: feat: Remove legacy sql alchemy db connection link from G Sheet connection
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19450:
URL: https://github.com/apache/superset/pull/19450#issuecomment-1083683224
# [Codecov](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19450](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35b0a78) into [master](https://codecov.io/gh/apache/superset/commit/a4c261d72c3f2c26d443cb202fb79d168fab6c93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4c261d) will **decrease** coverage by `0.05%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #19450 +/- ##
==========================================
- Coverage 66.59% 66.53% -0.06%
==========================================
Files 1670 1672 +2
Lines 63888 63953 +65
Branches 6510 6520 +10
==========================================
+ Hits 42544 42553 +9
- Misses 19655 19709 +54
- Partials 1689 1691 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.25% <50.00%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `33.01% <50.00%> (+0.21%)` | :arrow_up: |
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `67.79% <0.00%> (-3.64%)` | :arrow_down: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `60.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/embedded/index.tsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2luZGV4LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...rc/dashboard/components/DashboardEmbedControls.tsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEVtYmVkQ29udHJvbHMudHN4) | `8.16% <0.00%> (ø)` | |
| [...ontend/src/dashboard/containers/DashboardRoute.tsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFJvdXRlLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `5.31% <0.00%> (+0.05%)` | :arrow_up: |
| [...rset-frontend/src/hooks/apiResources/dashboards.ts](https://codecov.io/gh/apache/superset/pull/19450/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9kYXNoYm9hcmRzLnRz) | `36.36% <0.00%> (+3.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4c261d...35b0a78](https://codecov.io/gh/apache/superset/pull/19450?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #19450: feat: Remove legacy sql alchemy db connection link from G Sheet connection
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #19450:
URL: https://github.com/apache/superset/pull/19450#discussion_r840787199
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -1318,32 +1318,36 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
validationErrors={validationErrors}
/>
<div css={(theme: SupersetTheme) => infoTooltip(theme)}>
- <Button
- data-test="sqla-connect-btn"
- buttonStyle="link"
- onClick={() =>
- setDB({
- type: ActionType.configMethodChange,
- payload: {
- engine: db.engine,
- configuration_method:
- CONFIGURATION_METHOD.SQLALCHEMY_URI,
- database_name: db.database_name,
- },
- })
- }
- css={buttonLinkStyles}
- >
- {t(
- 'Connect this database with a SQLAlchemy URI string instead',
- )}
- </Button>
- <InfoTooltip
- tooltip={t(
- 'Click this link to switch to an alternate form that allows you to input the SQLAlchemy URL for this database manually.',
- )}
- viewBox="0 -6 24 24"
- />
+ {dbModel.name !== 'Google Sheets' && (
Review comment:
can we check the engine against `gsheets` instead?
It's done like that in the same file, so if we can, we should use the same checking method.
And probably move that `gsheets` engine string to a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org