You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/10/14 07:09:16 UTC
[GitHub] [openwhisk] style95 opened a new pull request #4998: [WIP] Release 1.0.0
style95 opened a new pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998
This is to release OpenWhisk core 1.0.0 and fix tags from the `nightly` to a fixed tag.
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-708208352
This PR would not be merged.
This is a branch in the Apache repo and would preserve a snapshot for the 1.0.0 version.
Reference: https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md#preparing-to-make-a-release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#discussion_r509371349
##########
File path: ansible/files/runtimes.json
##########
@@ -205,7 +191,7 @@
"image": {
"prefix": "openwhisk",
"name": "action-golang-v1.11",
Review comment:
Good point. We should drop go-v1.11 imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] dgrove-oss commented on a change in pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#discussion_r507886431
##########
File path: ansible/files/runtimes.json
##########
@@ -262,7 +248,7 @@
"image": {
"prefix": "openwhisk",
"name": "action-ballerina-v0.990.2",
- "tag": "nightly"
+ "tag": "nightly" // Todo: Need to use a fixed tag after releasing the runtime
Review comment:
I think we should probably drop ballerina from 1.0.0 branch, but I will defer to @rabbah. I think ballerina 1.2.x is out now, so if we did want to support it, the "right" thing to do is update the runtime to a newer version of ballerina, then release it, then use that tag. I don't think we should hold 1.0.0 of OpenWhisk to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #4998: [DO NOT MERGE] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-724577648
closing as the 1.0.0 version is released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io commented on pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-713252003
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=h1) Report
> Merging [#4998](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/a1ba98778e3db80a06fe707c47c5f4c05d8b85ee?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4998 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 202 202
Lines 9786 9786
Branches 409 409
=======================================
Hits 8196 8196
Misses 1590 1590
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=footer). Last update [a1ba987...1b4cadc](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on a change in pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#discussion_r507699346
##########
File path: ansible/files/runtimes.json
##########
@@ -262,7 +248,7 @@
"image": {
"prefix": "openwhisk",
"name": "action-ballerina-v0.990.2",
- "tag": "nightly"
+ "tag": "nightly" // Todo: Need to use a fixed tag after releasing the runtime
Review comment:
I noticed there is no released version of this runtime and it's even not listed in the website.
Should we release this runtime first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on a change in pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#discussion_r509131797
##########
File path: ansible/files/runtimes.json
##########
@@ -205,7 +191,7 @@
"image": {
"prefix": "openwhisk",
"name": "action-golang-v1.11",
Review comment:
Should we keep go-v1.11 along with go-v1.15?
Reference: [GO-EOL](https://endoflife.date/go)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io edited a comment on pull request #4998: [DO NOT MERGE] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-713252003
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=h1) Report
> Merging [#4998](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/65cb7e373ed6bae8b65f3edac2433026fb7b373f?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4998 +/- ##
==========================================
- Coverage 83.78% 83.76% -0.03%
==========================================
Files 202 202
Lines 9786 9786
Branches 409 409
==========================================
- Hits 8199 8197 -2
- Misses 1587 1589 +2
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rg/apache/openwhisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0.00%> (-3.85%)` | :arrow_down: |
| [...pache/openwhisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `88.50% <0.00%> (-1.15%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=footer). Last update [65cb7e3...99a2fbd](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io edited a comment on pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-713252003
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=h1) Report
> Merging [#4998](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/a1ba98778e3db80a06fe707c47c5f4c05d8b85ee?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4998 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 202 202
Lines 9786 9786
Branches 409 409
=======================================
Hits 8196 8196
Misses 1590 1590
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=footer). Last update [a1ba987...1b4cadc](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] dgrove-oss commented on pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-712282523
I will see if I can manage to convince the Jenkins job to build the right core Docker images from the 1.0.0 branch. Might not have time until later tonight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #4998: [DO NOT MERGE] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-717287155
Now, this branch includes these two new commits.
And I think it is finally ready to be released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 closed pull request #4998: [DO NOT MERGE] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 closed pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io edited a comment on pull request #4998: [DO NOT MERGE] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-713252003
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=h1) Report
> Merging [#4998](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/65cb7e373ed6bae8b65f3edac2433026fb7b373f?el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4998 +/- ##
==========================================
+ Coverage 83.78% 83.85% +0.07%
==========================================
Files 202 202
Lines 9786 9786
Branches 409 409
==========================================
+ Hits 8199 8206 +7
+ Misses 1587 1580 -7
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pache/openwhisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `88.50% <0.00%> (-1.15%)` | :arrow_down: |
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <0.00%> (-0.80%)` | :arrow_down: |
| [.../scala/org/apache/openwhisk/utils/Exceptions.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL3V0aWxzL0V4Y2VwdGlvbnMuc2NhbGE=) | `40.00% <0.00%> (+20.00%)` | :arrow_up: |
| [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `80.00% <0.00%> (+20.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=footer). Last update [65cb7e3...99a2fbd](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-io edited a comment on pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#issuecomment-713252003
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=h1) Report
> Merging [#4998](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/a1ba98778e3db80a06fe707c47c5f4c05d8b85ee?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4998 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 202 202
Lines 9786 9786
Branches 409 409
=======================================
Hits 8196 8196
Misses 1590 1590
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../org/apache/openwhisk/core/connector/Message.scala](https://codecov.io/gh/apache/openwhisk/pull/4998/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29ubmVjdG9yL01lc3NhZ2Uuc2NhbGE=) | `79.36% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=footer). Last update [a1ba987...1b4cadc](https://codecov.io/gh/apache/openwhisk/pull/4998?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on a change in pull request #4998: [WIP] Release 1.0.0
Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #4998:
URL: https://github.com/apache/openwhisk/pull/4998#discussion_r507701445
##########
File path: ansible/files/runtimes.json
##########
@@ -71,27 +71,13 @@
}
],
"python": [
- {
Review comment:
Python2 would be officially gone from the 1.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org