You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/23 15:31:45 UTC

[GitHub] [pulsar] dlg99 commented on pull request #10330: Fix message buffer being copied from direct memory to heap memory

dlg99 commented on pull request #10330:
URL: https://github.com/apache/pulsar/pull/10330#issuecomment-825738761


   @codelipenghui nice catch. The checksum part should be easy to fix, DigestManager.computeDigestAndPackageForSending can check if ByteBuf is an instance of CompositeByteBuf, treat it as Iterable<ByteBuf> (implemented by CompositeByteBuf), update digest in a loop. Or something along these lines.
   PCBC.addEntry is doing something similar with ByteBufList. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org