You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "etseidl (via GitHub)" <gi...@apache.org> on 2026/06/04 22:07:36 UTC
[I] Verification script should pull test repos with `git submodule` [arrow-rs]
etseidl opened a new issue, #10078:
URL: https://github.com/apache/arrow-rs/issues/10078
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
An issue came up while building a release candidate for 59.0.0 (#9110). The current verification script pulls test data directly from their respective repos
https://github.com/apache/arrow-rs/blob/9f96a8f5c3f47c6303c7d17ac7f00ad4ad0df513/dev/release/verify-release-candidate.sh#L114-L116
This caused verification to fail because a new file was recently added to parquet-testing/bad_data, which caused the arrow_reader/bad_data test to fail (it checks for new files that haven't yet had tests added).
**Describe the solution you'd like**
To avoid this issue in the future, I think it would be better for the script to instead invoke `git submodule update --init` to pull the testing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Verification script should pull test repos with `git submodule` [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #10078: Verification script should pull test repos with `git submodule`
URL: https://github.com/apache/arrow-rs/issues/10078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Verification script should pull test repos with `git submodule` [arrow-rs]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on issue #10078:
URL: https://github.com/apache/arrow-rs/issues/10078#issuecomment-6188021534
I just ran into this when testing the 59.3.1 release. I'm not sure that it makes sense to use a git submodule though, as the commit checked out when running the verification script might not match the release version. Maybe the `test_invalid_files` test should just be skipped when running the verification script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org