You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2026/06/09 01:43:59 UTC
[I] Review licenses for spark 4 client [polaris]
MonkeyCanCode opened a new issue, #4663:
URL: https://github.com/apache/polaris/issues/4663
### Describe the bug
From https://github.com/apache/polaris/pull/4612, spark 4.0 client support is added. We should review the license again before next release.
### To Reproduce
_No response_
### Actual Behavior
_No response_
### Expected Behavior
_No response_
### Additional context
_No response_
### System information
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b closed issue #4663: Review licenses for spark 4 client
URL: https://github.com/apache/polaris/issues/4663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4667190938
@MonkeyCanCode yea I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4672737942
(closed by mistake 🤦 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4666788569
Hello @jbonofre / @flyrain / @dimas-b ,
Looking at the license/notice for spark client (both 3 and 4), they are actually the same as there is no change of dependencies. So the current one for spark 4 should be valid is spark 3 is valid. While doing this exercise, I noticed the following potential "issues":
1. Missing notice
We are missing notice for `datasketches-java` (it is from Iceberg) and FastDoubleParser from jack (this one is partially included from Jackson). Do we need to implicitly add those or will the current one be sufficient?
2. Missing license
We are missing license for Schubfach (used by Jackson). Do we need to implicitly add those or will the current one be sufficient?
Beside these 2, we should be okay with the license for spark 4. The only thing which we may want to discuss is https://github.com/apache/polaris/blob/14e2871bf6bc6062e5784aa73dff4113f095d17d/plugins/spark/v4.0/spark/BUNDLE-LICENSE#L207-L208 which they are a bit diff now compared to the one in spark 3.5. Do we still classify them as used from Iceberg?
Thanks,
Yong Zheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4665107706
Made some progress here. I will raise a PR later tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4666869424
Dataskeches notice is not required as it's an ASF project. We should include NOTICE only for Apache licensed projects not from the ASF (and providing notice).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4667133859
> Dataskeches notice is not required as it's an ASF project. We should include NOTICE only for Apache licensed projects not from the ASF (and providing notice).
Got it. Thanks for the explanation. Mind take a look at https://github.com/apache/polaris/blob/14e2871bf6bc6062e5784aa73dff4113f095d17d/plugins/spark/v4.0/spark/BUNDLE-LICENSE#L207-L208 if we need to include/exclude them.
Thanks,
Yong Zheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on issue #4663:
URL: https://github.com/apache/polaris/issues/4663#issuecomment-4672735571
AI (Codex) analysis:
```
About 38% of PolarisRESTCatalog’s implementation lines are shared with Iceberg’s RESTSessionCatalog.
```
For `BasePolarisSparkCatalog`:
```
So I’d cite about 47% meaningful exact source-line overlap, or about 63% if counting all implementation lines including Spark interface boilerplate. The ordered block similarity is much lower, around 29% best-window, so this looks more like a wrapper using the same Spark catalog API than a direct line-by-line copy of an Iceberg class.
```
My take: both `PolarisRESTCatalog` and `BasePolarisSparkCatalog` are independent Polaris classes now, "inspired by" Iceberg code, but not a full "copy".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Review licenses for spark 4 client [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode closed issue #4663: Review licenses for spark 4 client
URL: https://github.com/apache/polaris/issues/4663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org