You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/05 01:51:49 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3914: ARTEMIS-3645 Support broker balancer cache persistence

jbertram commented on pull request #3914:
URL: https://github.com/apache/activemq-artemis/pull/3914#issuecomment-1030494024


   Nice work, @brusdev. My only concern is with the XML/XSD change. Any configuration using the existing `cache-timeout` element  will fail to parse upon upgrade. I sympathize with your change to group all the `cache` elements together, but we need to maintain backwards compatibility. I see two options:
   
    1. Keep the existing `cache-timeout`, but deprecate it and add the new `cache` subsection.
    2. Add a new element like `cache-persistence` on the same level as the existing `cache-timeout`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org