You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Thorsten Schöning <ts...@am-soft.de> on 2019/09/16 13:15:52 UTC
Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Hi all,
I'm trying to build Wicket 7.15.0 from source using Java 8:
> openjdk version "1.8.0_222"
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10)
> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode)
This fails in Wicket Util already with lots of Javadoc-related errors.
I know that the reason this happens is because of enabled linting for
Javadoc in Java 8 by default, but earlier versions of Wicket 7
implemented a workaround. That workaround has been removed without any
further notice on why and what the alternative is:
https://github.com/apache/wicket/commit/ee1b8b37dbe5b34c63a33d65f84b26cbd38080d4
https://github.com/apache/wicket/commit/d7416a325338a7d229c9e25f4d6852f0c83775eb
So, how am I supposed to build Wicket 7 using Java 8 these days?
Thanks!
Mit freundlichen Grüßen,
Thorsten Schöning
--
Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme http://www.AM-SoFT.de/
Telefon...........05151- 9468- 55
Fax...............05151- 9468- 88
Mobil..............0178-8 9468- 04
AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello,
please use `buildbot` profile
On Mon, 16 Sep 2019 at 20:16, Thorsten Schöning <ts...@am-soft.de>
wrote:
> Hi all,
>
> I'm trying to build Wicket 7.15.0 from source using Java 8:
>
> > openjdk version "1.8.0_222"
> > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_222-b10)
> > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode)
>
> This fails in Wicket Util already with lots of Javadoc-related errors.
> I know that the reason this happens is because of enabled linting for
> Javadoc in Java 8 by default, but earlier versions of Wicket 7
> implemented a workaround. That workaround has been removed without any
> further notice on why and what the alternative is:
>
>
> https://github.com/apache/wicket/commit/ee1b8b37dbe5b34c63a33d65f84b26cbd38080d4
>
> https://github.com/apache/wicket/commit/d7416a325338a7d229c9e25f4d6852f0c83775eb
>
> So, how am I supposed to build Wicket 7 using Java 8 these days?
>
> Thanks!
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
> AM-SoFT IT-Systeme http://www.AM-SoFT.de/
>
> Telefon...........05151- 9468- 55
> Fax...............05151- 9468- 88
> Mobil..............0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
--
WBR
Maxim aka solomax
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Thorsten Schöning <ts...@am-soft.de>.
Guten Tag Martin Grigorov,
am Dienstag, 17. September 2019 um 20:00 schrieben Sie:
> For me the important thing is to cut releases with Java 7. Any non-release
> build could be done with any other version of Java 7+.
> @Thorsten feel free to send a Pull Request!
Thanks for the clarification, but I changed my build back to JDK 7
already, as I need it for WicketStuff as well. The goal is to go
forward to Wicket 8 anyway, just wanted to have something current
working.
If need arises, I will send a PR, but until then I'm simply going to
document my changes here:
https://github.com/ams-ts-wicket/wicket/commit/1074124f33e01076c327aea3a18a616ef517f9fb
Mit freundlichen Grüßen,
Thorsten Schöning
--
Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme http://www.AM-SoFT.de/
Telefon...........05151- 9468- 55
Fax...............05151- 9468- 88
Mobil..............0178-8 9468- 04
AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Martin Grigorov <mg...@apache.org>.
Maxim,
With -Pbuildbot it will try to find Java7 entry and if the developer does
not have it (and most probably (s)he won't have it because it is ancient
and it is hard to find a download link for it) then it will fail the build.
What Thorsten complains is: why the profile has been removed at all. I
don't remember whether there was discussion about this or not.
For me the important thing is to cut releases with Java 7. Any non-release
build could be done with any other version of Java 7+.
@Thorsten feel free to send a Pull Request!
On Tue, Sep 17, 2019 at 10:36 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello Thorsten,
>
> you can build using `mvn clean install -Pbuildbot`
> This way toolchains will be used
>
> On Tue, 17 Sep 2019 at 14:35, Thorsten Schöning <ts...@am-soft.de>
> wrote:
>
> > Guten Tag Martin Grigorov,
> > am Dienstag, 17. September 2019 um 03:54 schrieben Sie:
> >
> > > Wicket 7.x is being built with Java 7, not with Java 8.
> >
> > Support to build with Java 8 has been implemented in the past. Why is
> > removing that not a regression? Especially because you don't nail
> > things to JDK 7 like WicketStuff seems to do using toolchains.
> >
> > Your own docs don't distinguish between runtime and building things as
> > well:
> >
> > > This Wicket version requires at least the following Java version:
> > > JDK 7.0 or newer.
> >
> > https://wicket.apache.org/start/wicket-7.x.html#status
> >
> > There are others building Wicket 7 with Java 8 as well and you did
> > commit changes to support that:
> >
> > https://issues.apache.org/jira/browse/WICKET-6615
> >
> >
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3Cabaaada6-4581-e009-607f-4ecd04b88304@meiers.net%3E
> >
> >
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3CCAJmbs8jH687UNhazbryR+XhEJYSCKKL89MPnk7YSgtmCBReYpg@mail.gmail.com%3E
> >
> > Doesn't make much sense to commit support for JDK 8 more than once
> > and remove it "silently" afterwards. Especially because the current
> > master for Wicket 9 contains support to be build with JDK 12 and 13 as
> > well instead of JDK 9 only. Any plans to remove that already? :-)
> >
> > Mit freundlichen Grüßen,
> >
> > Thorsten Schöning
> >
> > --
> > Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
> > AM-SoFT IT-Systeme http://www.AM-SoFT.de/
> >
> > Telefon...........05151- 9468- 55
> > Fax...............05151- 9468- 88
> > Mobil..............0178-8 9468- 04
> >
> > AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> > AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
> >
> >
>
> --
> WBR
> Maxim aka solomax
>
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Thorsten,
you can build using `mvn clean install -Pbuildbot`
This way toolchains will be used
On Tue, 17 Sep 2019 at 14:35, Thorsten Schöning <ts...@am-soft.de>
wrote:
> Guten Tag Martin Grigorov,
> am Dienstag, 17. September 2019 um 03:54 schrieben Sie:
>
> > Wicket 7.x is being built with Java 7, not with Java 8.
>
> Support to build with Java 8 has been implemented in the past. Why is
> removing that not a regression? Especially because you don't nail
> things to JDK 7 like WicketStuff seems to do using toolchains.
>
> Your own docs don't distinguish between runtime and building things as
> well:
>
> > This Wicket version requires at least the following Java version:
> > JDK 7.0 or newer.
>
> https://wicket.apache.org/start/wicket-7.x.html#status
>
> There are others building Wicket 7 with Java 8 as well and you did
> commit changes to support that:
>
> https://issues.apache.org/jira/browse/WICKET-6615
>
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3Cabaaada6-4581-e009-607f-4ecd04b88304@meiers.net%3E
>
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3CCAJmbs8jH687UNhazbryR+XhEJYSCKKL89MPnk7YSgtmCBReYpg@mail.gmail.com%3E
>
> Doesn't make much sense to commit support for JDK 8 more than once
> and remove it "silently" afterwards. Especially because the current
> master for Wicket 9 contains support to be build with JDK 12 and 13 as
> well instead of JDK 9 only. Any plans to remove that already? :-)
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
> AM-SoFT IT-Systeme http://www.AM-SoFT.de/
>
> Telefon...........05151- 9468- 55
> Fax...............05151- 9468- 88
> Mobil..............0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>
--
WBR
Maxim aka solomax
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Thorsten Schöning <ts...@am-soft.de>.
Guten Tag Martin Grigorov,
am Dienstag, 17. September 2019 um 03:54 schrieben Sie:
> Wicket 7.x is being built with Java 7, not with Java 8.
Support to build with Java 8 has been implemented in the past. Why is
removing that not a regression? Especially because you don't nail
things to JDK 7 like WicketStuff seems to do using toolchains.
Your own docs don't distinguish between runtime and building things as
well:
> This Wicket version requires at least the following Java version:
> JDK 7.0 or newer.
https://wicket.apache.org/start/wicket-7.x.html#status
There are others building Wicket 7 with Java 8 as well and you did
commit changes to support that:
https://issues.apache.org/jira/browse/WICKET-6615
http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3Cabaaada6-4581-e009-607f-4ecd04b88304@meiers.net%3E
http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3CCAJmbs8jH687UNhazbryR+XhEJYSCKKL89MPnk7YSgtmCBReYpg@mail.gmail.com%3E
Doesn't make much sense to commit support for JDK 8 more than once
and remove it "silently" afterwards. Especially because the current
master for Wicket 9 contains support to be build with JDK 12 and 13 as
well instead of JDK 9 only. Any plans to remove that already? :-)
Mit freundlichen Grüßen,
Thorsten Schöning
--
Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme http://www.AM-SoFT.de/
Telefon...........05151- 9468- 55
Fax...............05151- 9468- 88
Mobil..............0178-8 9468- 04
AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Martin Grigorov <ma...@gmail.com>.
Hi,
Wicket 7.x is being built with Java 7, not with Java 8.
On Mon, Sep 16, 2019, 18:52 Thorsten Schöning <ts...@am-soft.de> wrote:
> Guten Tag Thorsten Schöning,
> am Montag, 16. September 2019 um 15:15 schrieben Sie:
>
> >
> https://github.com/apache/wicket/commit/ee1b8b37dbe5b34c63a33d65f84b26cbd38080d4
> >
> https://github.com/apache/wicket/commit/d7416a325338a7d229c9e25f4d6852f0c83775eb
>
> > So, how am I supposed to build Wicket 7 using Java 8 these days?
>
> Reintroducing the formerly available workaround fixes things and let
> me build Wicket 7 again:
>
>
> https://github.com/ams-ts-wicket/wicket/commit/1074124f33e01076c327aea3a18a616ef517f9fb
>
> But what is the correct thing to do in the end? I have the feeling
> it's reverting the removal of the workaround, especially because such
> workarounds have been accidently removed in the past already:
>
>
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3Cee8b3e9e-511d-7f2a-730c-52f5b0adb6a7%40gmail.com%3E
>
> https://github.com/apache/wicket/commit/1784efa2b649da3f9f857beef1aa8b4deb3c7b42
>
> From what I see, that wrong revert hasn't been corrected yet as well:
>
> https://github.com/apache/wicket/blob/wicket-7.x/pom.xml#L862
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
> AM-SoFT IT-Systeme http://www.AM-SoFT.de/
>
> Telefon...........05151- 9468- 55
> Fax...............05151- 9468- 88
> Mobil..............0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>
Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.
Posted by Thorsten Schöning <ts...@am-soft.de>.
Guten Tag Thorsten Schöning,
am Montag, 16. September 2019 um 15:15 schrieben Sie:
> https://github.com/apache/wicket/commit/ee1b8b37dbe5b34c63a33d65f84b26cbd38080d4
> https://github.com/apache/wicket/commit/d7416a325338a7d229c9e25f4d6852f0c83775eb
> So, how am I supposed to build Wicket 7 using Java 8 these days?
Reintroducing the formerly available workaround fixes things and let
me build Wicket 7 again:
https://github.com/ams-ts-wicket/wicket/commit/1074124f33e01076c327aea3a18a616ef517f9fb
But what is the correct thing to do in the end? I have the feeling
it's reverting the removal of the workaround, especially because such
workarounds have been accidently removed in the past already:
http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3Cee8b3e9e-511d-7f2a-730c-52f5b0adb6a7%40gmail.com%3E
https://github.com/apache/wicket/commit/1784efa2b649da3f9f857beef1aa8b4deb3c7b42
From what I see, that wrong revert hasn't been corrected yet as well:
https://github.com/apache/wicket/blob/wicket-7.x/pom.xml#L862
Mit freundlichen Grüßen,
Thorsten Schöning
--
Thorsten Schöning E-Mail: Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme http://www.AM-SoFT.de/
Telefon...........05151- 9468- 55
Fax...............05151- 9468- 88
Mobil..............0178-8 9468- 04
AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow