[jira] [Commented] (ASTERIXDB-1471) ADM DataParser/Lexer outputs wrong line number for exception

["Xikui Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASTERIXDB-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315999#comment-15315999 ] 

Xikui Wang commented on ASTERIXDB-1471:
---------------------------------------

[~imaxon]

I think I found where the problem is. In AdmLexer, the line count is increased in both setBuffer and updateLineColumn. I think the line++; (line 88)  in setBuffer can be safely removed, since updateLineColumn covers better line count logic. 

AdmLexer is generated by Lexer.java . I think remove that line in Lexer.java will work. Also maybe the line number should be initialize as 1, since updateLineColumn increases ln after processing.



> ADM DataParser/Lexer outputs wrong line number for exception
> ------------------------------------------------------------
>
>                 Key: ASTERIXDB-1471
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1471
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: AsterixDB, Data Formats
>            Reporter: Ian Maxon
>
> When an ADM file contains invalid syntax according to the ADM loader, the wrong line number is given for the offending line. For some reason the given line # is 2x the actual one (so for 64052557 it would be 32026279). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)